[aws-sdk-cpp] Fix the path in the export cmake config#21240
Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom Nov 9, 2021
Merged
[aws-sdk-cpp] Fix the path in the export cmake config#21240dan-shaw merged 2 commits intomicrosoft:masterfrom
dan-shaw merged 2 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NancyLi1013
added
the
category:port-bug
NancyLi1013
approved these changes
Nov 8, 2021
NancyLi1013
added
the
info:needs-maintainer-attention
Contributor
|
LGTM, thanks for the fixes. @dg0yt |
NancyLi1013
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes the
AWSSDK_DEFAULT_ROOT_DIRin the export cmake config so that `find_package(AWSSDK) can actually suceed.(Discovered while, and needed for, testing the netcdf update, [netcdf-c] Update to 4.8.1, revise features #21239.)
Intentionally no other changes.
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no.
Does your PR follow the maintainer guide?
yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes.