[gdal] Add features for hdf5, netcdf, postgresql#21231
[gdal] Add features for hdf5, netcdf, postgresql#21231BillyONeal merged 19 commits intomicrosoft:masterfrom
Conversation
0fa580c to
5a8885d
Compare
c5bf7d5 to
6cc0a7e
Compare
|
Can you add a SPATIALITE_412_OR_LATER macro definition to libspatialite? The description of SPATIALITE_412_OR_LATER is in the nmake.opt file |
Thanks for the hint! |
This comment has been minimized.
This comment has been minimized.
I remember openssl's cmake wrapper doing this stuff. But why this regression happened? |
There are two other libs, but not user32.lib. I think this is okay for cmake because of the implicit link libraries which do contain user32.lib (but not the other two libs). |
|
Wait, I made that error note to the wrong PR initially, and forgot to hide it. Sorry for the noise. My comments apply to #20443. |
|
@BillyONeal vcpkg ci exception again on agent vcpkg-eg-mac-02, https://dev.azure.com/vcpkg/public/_build/results?buildId=64286&view=logs&j=7b75bd19-17d3-53d4-00fd-23f1a49a8ba4. |
scripts/ci.baseline.txt
Outdated
| # Requires ATL for ARM64 to be installed in CI | ||
| gdal:arm64-windows=fail | ||
| # Requires comsuppw[d].lib for UWP to be installed in CI | ||
| gdal:arm-uwp=fail | ||
| gdal:x64-uwp=fail |
There was a problem hiding this comment.
@BillyONeal Should we add these Visual Studio Components on our CI?
There was a problem hiding this comment.
I don't believe comsupp supports UWP at all.
There was a problem hiding this comment.
@dg0yt Can you double confirm that?
If gdal doesn't support arm or uwp, please move them to supports.
There was a problem hiding this comment.
I can't say much about gdal usage about uwp. I don't care if uwp is supported at all.
But gdal works well on all types of Android, including ARM.
There was a problem hiding this comment.
What I really don't understand is how the MSVC toolchains manage to pull in libs which are not installed or supported for the given platform. Why not fail early?
There was a problem hiding this comment.
@BillyONeal The open question was: Is ATLS.LIB for arm64-windows (not UWP!) missing intentionally, or doesn't it exist?
For desktop there is an ATL available for all the things:
Checking these boxes gives me:
"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\atlmfc\lib\arm64\atls.lib"
There was a problem hiding this comment.
So it is missing in the CI image only. This PR handles this correctly by the CI baseline entry.
There was a problem hiding this comment.
I think this means gdal:arm64-windows should be in ci.baseline.txt but there should be supports:!uwp since there seems to be no attempt by upstream to support that (if they need comsupp.lib and ATL)
There was a problem hiding this comment.
Oh I see you already did that
fd00ccd to
b17b4a7
Compare
|
x64-linux error is unrelated: |
|
libasound is provided by port alsa is not in opencv4's dependency list. Even not in ffmpeg's dependency list. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please merge this soon. The next GDAL release is waiting. |
|
Thanks for the update! |

What does your PR fix?
Adds feature control for hdf5, netcdf, postgresql.
Unblocks builds for arm64-windows
and uwp. (However, not successful in CI.) (UWP not supported due to comsupp lib.)Fixes finding expat debug lib on mingw.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, yes
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes