Skip to content

[gdal] Make available on arm#21194

Closed
m-kuhn wants to merge 2 commits intomicrosoft:masterfrom
opengisch:gdal_arm
Closed

[gdal] Make available on arm#21194
m-kuhn wants to merge 2 commits intomicrosoft:masterfrom
opengisch:gdal_arm

Conversation

@m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Nov 4, 2021

Describe the pull request

  • What does your PR fix?

Removes exclusion of gdal on arm.
This has been around forever, and it's hard to tell why it has been put there originally.
Builds fine here for android-arm, so I assume the cpu is not an issue.
If there are good reasons not to support arm, this PR shall be closed and a descriptive comment added instead, so once the issue has been fixed the port can be adapted accordingly.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

@dg0yt
Copy link
Contributor

dg0yt commented Nov 4, 2021

Unfortunately, the change is not tested in vcpkg CI: Some dependency is marked as failing or not supported on arm, and this cascades to gdal.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Nov 4, 2021

Some dependency is marked as failing or not supported on arm, and this cascades to gdal.

Sorry, I'm failing to follow the implications of this.

Where I'm coming from: it builds fine for arm-android
What I'd expect is: if a dependency is failing, gdal should be excluded implicitly, not explicitly

@dg0yt
Copy link
Contributor

dg0yt commented Nov 4, 2021

@m-kuhn I just wanted to point out that we cannot feel safe with all CI checks green because gdal:arm still is excluded implicitly.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Nov 4, 2021

@m-kuhn I just wanted to point out that we cannot feel safe with all CI checks green because gdal:arm still is excluded implicitly.

is or may be?
Whatever, even if there still is a problem somewhere else, this PR should help shifting the attention to the right spot.

@autoantwort
Copy link
Contributor

Works at least on arm64-osx

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 5, 2021
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 5, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Nov 5, 2021

We know that gdal works on arm from using gdal without vcpkg.
FTR it is hdf5 which is marked as failing on arm. Hdf5 may be hard to fix unless you can test it. But that problem should go away soon, when we turn hdf5 into a non-default feature.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 8, 2021

Building for arm doesn't work yet for windows targets (building with nmake). I adopted a modified version for the gdal 3.4.0 update in #21261. This should make this PR obsolete.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Nov 8, 2021

Very good news, I'm more than happy to let go

@m-kuhn m-kuhn closed this Nov 8, 2021
@m-kuhn m-kuhn deleted the gdal_arm branch November 8, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants