-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[arrow] Update to 6.0.0 #21113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[arrow] Update to 6.0.0 #21113
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f2aca27
Bump version to 6.0.0
ianmcook 87f881a
Update version files
ianmcook 9378eb9
Update patch
ianmcook d72e81c
Update version files
ianmcook fba1f3e
Update patch
ianmcook 8fcc127
Update version files
ianmcook b3be9e1
Update patch
ianmcook dfd81f5
Update version files
ianmcook 4167189
Fix deprecated functions
ianmcook b82e68d
Update version files
ianmcook 2d82e94
Fix unused variable warning
ianmcook 9eeacf6
Update version files
ianmcook 5227c9f
Enclose paths in quotes
ianmcook 4caaa34
Enclose paths in quotes
ianmcook 76904e0
Update version files
ianmcook d062b91
Fix S3 feature
ianmcook 9bc7e2b
Update version files
ianmcook 4c76bd8
Remove quotes from empty DZSTD_MSVC_LIB_PREFIX
ianmcook 706ae47
Update version files
ianmcook 11e2f47
Update version files
ianmcook 80e236c
Update version files
ianmcook 6b92916
Update version files
ianmcook 616feed
Remove old attempt to fix AWS SDK issue
ianmcook a8997be
Update versions files
ianmcook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set
THRIFT_SOURCEtoBUNDLEDrather than patching this?Will
BUNDLEDend up trying to use a vendored copy of thrift that might conflict with what other vcpkg ports are using?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the concern. We need to do some testing to investigate this further before making the change. I opened #21821 for the arrow port maintainers to investigate this. If it's OK with the vcpkg maintainers, we would prefer to address this after this PR is merged.