Skip to content

[quantlib] update to 1.24#21068

Merged
dan-shaw merged 17 commits intomicrosoft:masterfrom
sweemer:quantlib-v1.24
Nov 11, 2021
Merged

[quantlib] update to 1.24#21068
dan-shaw merged 17 commits intomicrosoft:masterfrom
sweemer:quantlib-v1.24

Conversation

@sweemer
Copy link
Copy Markdown
Contributor

@sweemer sweemer commented Oct 30, 2021

Update quantlib to v1.24.

static/dynamic on Linux and static on Windows, Yes

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@sweemer sweemer marked this pull request as ready for review October 30, 2021 06:41
@sweemer sweemer marked this pull request as draft October 31, 2021 02:26
@sweemer sweemer marked this pull request as ready for review October 31, 2021 06:03
@NancyLi1013 NancyLi1013 self-assigned this Nov 1, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 1, 2021
Comment thread ports/quantlib/vcpkg.json Outdated
Comment thread scripts/ci.baseline.txt Outdated
Comment thread ports/quantlib/vcpkg.json Outdated
Comment thread scripts/ci.baseline.txt Outdated
@sweemer sweemer marked this pull request as draft November 9, 2021 20:41
@sweemer sweemer marked this pull request as ready for review November 9, 2021 23:26
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 11, 2021
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/quantlib/portfile.cmake

@dan-shaw dan-shaw merged commit 7d3aeba into microsoft:master Nov 11, 2021
@sweemer sweemer deleted the quantlib-v1.24 branch November 11, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quantlib] update to 1.24

3 participants