[pcl] update pcl to 1.12.0#21027
[pcl] update pcl to 1.12.0#21027Alluofuyo wants to merge 23 commits intomicrosoft:masterfrom Alluofuyo:master
Conversation
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/pcl/portfile.cmake
remove the redundant patch
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e7e328cf9d3ce28cfd407fe4e052bb9e7f5c87a6 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/p-/pcl.json b/versions/p-/pcl.json
index 45f4e71..801a21c 100644
--- a/versions/p-/pcl.json
+++ b/versions/p-/pcl.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "dc5a93c590ea9f4d79643854039addf40acd6706",
+ "git-tree": "61cd01a143a157916dfc91a22c51acc7959b7278",
"version": "1.12.0",
"port-version": 0
},You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/pcl/portfile.cmake
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 843e0ba0d8f9c9c572e45564263eedfc7745e74f -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/p-/pcl.json b/versions/p-/pcl.json
index 01ec619..9cdf93d 100644
--- a/versions/p-/pcl.json
+++ b/versions/p-/pcl.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "38c298872294b3492aaa226d4f98f07798ae6875",
+ "git-tree": "b217f288dee0d0f7c2785fce1dd4d444087ffce8",
"version": "1.12.0",
"port-version": 0
},There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/rtabmap/portfile.cmake
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 843e0ba0d8f9c9c572e45564263eedfc7745e74f -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/r-/rtabmap.json b/versions/r-/rtabmap.json
index b61026b..13f6780 100644
--- a/versions/r-/rtabmap.json
+++ b/versions/r-/rtabmap.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "ae3cee7b1bb7d7b8a759ffb766b8db80371c6037",
+ "git-tree": "5c7b1735aee09f27a1a73651c00a529f9c4c3d90",
"version-string": "0.20.14",
"port-version": 0
},|
I've resolved the conflicts .It should be OK . Plz merge my PR , thanks! |
|
I have tested all the features in windows x86 , windows x64 , windows x64 static and linux x64 (ubuntu). But I have no environment in mac , so I didn't test these in mac os. @JonLiu1993 |
|
pcl is updating to 1.12.0 in PR #18855. |
OK, I'll close this PR soon. |
Describe the pull request
What does your PR fix?
update pcl to 1.12.0
Which triplets are supported/not supported? Have you updated the CI baseline?
all, noDoes your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?YesIf you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/