[script audit] Meson buildsystem#21026
Merged
BillyONeal merged 11 commits intomicrosoft:masterfrom Nov 8, 2021
Merged
Conversation
51 tasks
Contributor
Author
|
It must have some bugs here, let's see the result first. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Neumann-A
reviewed
Oct 28, 2021
Neumann-A
reviewed
Oct 28, 2021
Neumann-A
reviewed
Oct 28, 2021
Neumann-A
reviewed
Oct 28, 2021
Contributor
Author
|
|
Contributor
Author
|
@Neumann-A When building fontconfig: As you mentioned in #17956 (comment), that's a pixman bug. |
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
reviewed
Nov 2, 2021
PhoebeHui
removed
the
requires:vcpkg-team-review
Contributor
Author
The debug build uses release lib in D:/installed/x64-windows/lib. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil-ms
approved these changes
Nov 5, 2021
Contributor
Author
I can confirm b0a0f7f fixed this issue. |
PhoebeHui
approved these changes
Nov 8, 2021
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
Contributor
I don't think it is this PR. Vcpkg daily CI built fontconfig for 70033db, including this change. But #21173, merged a few hours ago, is a candidate for side effects. There are also version problems.
|
Contributor
|
Yeah meson version should really be forced! Seems like the min version stuff is btoken |
Contributor
|
The min version is no longer checked when the program is found in the system, #21173. |
Contributor
|
And the other possible trigger is the VM update. |
Member
Agreed.
I agree. It's strange that we got a clean run for it though :( .
Unlikely, because this also affects MacOS which don't participate in the normal VM update mechanism.
Hmmmmm yeah that doesn't seem intentional. I think we should continue the discussion over there. |
Contributor
|
yeah sorry bad bisect by me. I pointed at the wrong commit (i was also looking at the log to see what i was missing and got brain melted in between) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit the Meson build system according to the documentation.
Related: #17691