[openexr] Update to 3.1.4 #20957

chausner · 2021-10-23T22:50:45Z

Describe the pull request

What does your PR fix?

Updates openexr to 3.1.4. Also updates ports that directly or indirectly depend on openexr: devil, freeimage, ogre, osg
Which triplets are supported/not supported? Have you updated the CI baseline?

As before, Yes
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d78a0b47bdd4deb6bc5547e06e289672892ed226 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/o-/openexr.json b/versions/o-/openexr.json
index 8c0a5d8..7a1c966 100644
--- a/versions/o-/openexr.json
+++ b/versions/o-/openexr.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "0847323650d49af83fea1cc05c19ed046facbdf1",
+      "git-tree": "2c8b4ccfd87d7c78a84b20a5978cb50d29ca0700",
       "version": "3.1.2",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for osg but no changes to version or port version.
-- Version: 3.6.5#10
-- Old SHA: 233201eee3ebfaaac75ba9696d12209e9a1fbc32
-- New SHA: fc45c81eab3a137e76a5a2c58427e4b56572a6c6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d78a0b47bdd4deb6bc5547e06e289672892ed226 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 0009d79..753f41c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5010,7 +5010,7 @@
     },
     "osg": {
       "baseline": "3.6.5",
-      "port-version": 11
+      "port-version": 10
     },
     "osg-qt": {
       "baseline": "Qt5",
diff --git a/versions/o-/osg.json b/versions/o-/osg.json
index f7487e5..6ca076e 100644
--- a/versions/o-/osg.json
+++ b/versions/o-/osg.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "fc45c81eab3a137e76a5a2c58427e4b56572a6c6",
-      "version": "3.6.5",
-      "port-version": 11
-    },
     {
       "git-tree": "233201eee3ebfaaac75ba9696d12209e9a1fbc32",
       "version-string": "3.6.5",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

chausner · 2022-04-10T10:49:55Z

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for devil but no changes to version or port version.
-- Version: 1.8.0#9
-- Old SHA: 8a9e4a06645f23783644e618a677cdebf68148cc
-- New SHA: 9969a0f6854657eca4923d8619078530164f1c4c
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

dg0yt · 2022-04-10T12:42:46Z

Thanks for the update.

openimageio

This is the port where I got stuck recently when I tried to use it (i.e. test it) together with opencolorio, due to half/imath library issues, cf. #23918. That's why I was looking for related PRs and came to this one.

simogasp · 2022-04-22T08:42:10Z

@PhoebeHui @chausner @fabiencastan
Since OpenEXR 3.0 introduced so many changes in terms of building (modern cmake) and the split into different libraries, wouldn't it make sense to have a port openexr3 like we already have for opencv (opencv3, opencv4). It will make things much easier because the ports that want to upgrade to > 3.0 can do it properly in their source code instead of creating patches here, and people who really need to have openexr 3 in vcpkg to link with their own project won't be stuck.

I know it's not ideal in terms of maintenance, but since it has been done for opencv it think it's the best solution. It's a very particular case because the changes introduced in openexr 3 are so radical that it's almost impossible to manage the compatibility between the two versions (I mean in terms of building rules/cmake) without writing a lot of cmake code that will have to take into account so many corner cases.

And in the medium term we can declare the original openxr deprecated to "force" maintainers of the ports to transition to the new way of importing. (or renaming the current openxr port as openexr2 and leave a openxr port for the version above 3, so that we won't have to have an openxr4 when version 4 is released and so on)

JackBoosY · 2022-06-10T08:10:38Z

Any update on this PR?

chausner · 2022-06-10T17:16:51Z

Any update on this PR?

I am going to close this MR but I'll keep the branch in case somebody else wants to continue where I left off or try the approach suggested by @simogasp.

simogasp · 2022-06-10T19:32:17Z

@JackBoosY What do you think about that proposal of mine? Does it seem reasonable?
If I have time I might give it a try

JackBoosY · 2022-06-13T08:04:06Z

@simogasp Agreed.

chausner added 2 commits October 24, 2021 00:50

Update openexr to 3.1.2

02c2316

Update CI baseline

32d3d13

github-actions bot approved these changes Oct 23, 2021

View reviewed changes

chausner added 2 commits October 24, 2021 03:28

Try to fix git FetchContent issue on Windows

7acc150

Update git-tree hash

37df542

github-actions bot approved these changes Oct 24, 2021

View reviewed changes

chausner marked this pull request as draft October 24, 2021 01:32

chausner added 2 commits October 24, 2021 13:06

Workaround Imath find_dependency issue

ae0acae

Update git-tree hash

90b8edd

github-actions bot approved these changes Oct 24, 2021

View reviewed changes

Use separate imath dependency

2b7d178

PhoebeHui self-assigned this Oct 24, 2021

PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Oct 25, 2021

fabiencastan mentioned this pull request Oct 28, 2021

[cmake] all-in-one: Upgrade dependencies alicevision/AliceVision#1127

Merged

5 tasks

chausner added 4 commits October 30, 2021 01:49

Merge branch 'master' into openexr-3.1.2

454a9c8

Make freeimage compatible with openexr and imath

4ae84bf

Update CI baseline

0814c91

Merge branch 'freeimage-openexr-3.1.2' into openexr-3.1.2

16f9452

github-actions bot requested changes Oct 30, 2021

View reviewed changes

chausner added 3 commits October 30, 2021 16:07

Remove unused patch

b187747

Fix openexr dependency in osg

6e2f3cc

Update CI baseline

b145213

github-actions bot requested changes Oct 30, 2021

View reviewed changes

chausner added 2 commits October 30, 2021 16:15

Increment port-version of osg

04f39a0

Update CI baseline

3309a8e

github-actions bot approved these changes Oct 30, 2021

View reviewed changes

chausner added 2 commits October 30, 2021 16:27

Modernize osg

67af2d7

Update CI baseline

2fa8d07

github-actions bot approved these changes Oct 30, 2021

View reviewed changes

Fix osg build

2c37a7e

github-actions bot approved these changes Apr 9, 2022

View reviewed changes

chausner added 2 commits April 9, 2022 22:30

Fix OpenEXR compatibility in ogre

5fb72aa

Update CI baseline

57ab113

github-actions bot approved these changes Apr 9, 2022

View reviewed changes

chausner changed the title ~~[openexr] Update to 3.1.3~~ [openexr] Update to 3.1.4 Apr 9, 2022

chausner added 3 commits April 10, 2022 01:56

osg: Switch back to vcpkg_configure_cmake

552ea4b

Various fixes in osg

45be7aa

Update CI baseline

d8d099f

github-actions bot approved these changes Apr 10, 2022

View reviewed changes

chausner added 2 commits April 10, 2022 12:37

Fix OpenEXR in devil

9d35fed

Update CI baseline

1feecb0

github-actions bot approved these changes Apr 10, 2022

View reviewed changes

chausner added 2 commits April 10, 2022 13:04

Fix devil on macOS

f84687b

Update CI baseline

347a52e

github-actions bot requested changes Apr 10, 2022

View reviewed changes

github-actions bot approved these changes Apr 10, 2022

View reviewed changes

Thomas1664 mentioned this pull request Apr 19, 2022

[openexr] Update to 3.1.5 #24249

Closed

fabiencastan mentioned this pull request Apr 22, 2022

AliceVision needs to be updated for modern OpenEXR alicevision/AliceVision#1167

Closed

JackBoosY self-assigned this Jun 10, 2022

chausner closed this Jun 10, 2022

simogasp mentioned this pull request Jun 14, 2022

[openexr3] Add new port #25238

Closed

This was referenced Sep 16, 2022

[openexr] Side-by-side installation of version 2 and 3 #26788

Closed

[openexr] Update from 2 to 3.1.5, patch all consuming ports #26862

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[openexr] Update to 3.1.4 #20957

[openexr] Update to 3.1.4 #20957

chausner commented Oct 23, 2021 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

chausner commented Apr 10, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

dg0yt commented Apr 10, 2022

simogasp commented Apr 22, 2022 •

edited

Loading

JackBoosY commented Jun 10, 2022

chausner commented Jun 10, 2022

simogasp commented Jun 10, 2022

JackBoosY commented Jun 13, 2022

[openexr] Update to 3.1.4 #20957

[openexr] Update to 3.1.4 #20957

Conversation

chausner commented Oct 23, 2021 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

chausner commented Apr 10, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt commented Apr 10, 2022

simogasp commented Apr 22, 2022 • edited Loading

JackBoosY commented Jun 10, 2022

chausner commented Jun 10, 2022

simogasp commented Jun 10, 2022

JackBoosY commented Jun 13, 2022

chausner commented Oct 23, 2021 •

edited

Loading

chausner commented Apr 10, 2022 •

edited

Loading

simogasp commented Apr 22, 2022 •

edited

Loading