Skip to content

[vcpkg_configure_qmake] update to use qmake from Qt6#20935

Closed
MehdiChinoune wants to merge 1 commit intomicrosoft:masterfrom
MehdiChinoune:vcpkg-qmake-qt6
Closed

[vcpkg_configure_qmake] update to use qmake from Qt6#20935
MehdiChinoune wants to merge 1 commit intomicrosoft:masterfrom
MehdiChinoune:vcpkg-qmake-qt6

Conversation

@MehdiChinoune
Copy link
Contributor

@MehdiChinoune MehdiChinoune commented Oct 22, 2021

Describe the pull request

  • What does your PR fix?

    Fixes 20933

  • Which triplets are supported/not supported? Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@MehdiChinoune
Copy link
Contributor Author

@JackBoosY @Neumann-A

@Neumann-A
Copy link
Contributor

Please close this PR. Qt6 will not be supported by the normal scripts but by a port-script instead which gets installed by qtbase

@MehdiChinoune
Copy link
Contributor Author

MehdiChinoune commented Oct 22, 2021

Please close this PR. Qt6 will not be supported by the normal scripts but by a port-script instead which gets installed by qtbase

Are you going to push a PR to fix #20933 ?

@MehdiChinoune MehdiChinoune reopened this Oct 22, 2021
@MehdiChinoune MehdiChinoune marked this pull request as draft October 22, 2021 19:28
@MehdiChinoune MehdiChinoune marked this pull request as ready for review October 23, 2021 02:46
@cenit
Copy link
Contributor

cenit commented Oct 23, 2021

Please close this PR. Qt6 will not be supported by the normal scripts but by a port-script instead which gets installed by qtbase

there is nothing stopping ports to be ported to vcpkg_qmake_configure when that machinery is ready. In the meantime, if the fixes just work, why not?

@Neumann-A
Copy link
Contributor

In the meantime, if the fixes just work, why not?

because it does not fix the issue that the toolchain is not forwarded.
If something does not work I am typically the person who gets cced?
Qt6 is currently rather clean and I don't want to introduce any hacks which this is.

try to use #20963 instead

@cenit
Copy link
Contributor

cenit commented Oct 24, 2021

If something does not work I am typically the person who gets cced

perfectly understood your point

@MehdiChinoune MehdiChinoune deleted the vcpkg-qmake-qt6 branch October 26, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants