[openssl] Fix exported config#20831
Conversation
dg0yt
left a comment
There was a problem hiding this comment.
Concerning risk: some ports may suddenly start to discover openssl via png-config.
JackBoosY
left a comment
There was a problem hiding this comment.
Did you test the usage?
CMake: No. I think it is safe to assume that it works as well as CMake's recent changes, and that at least one port tested in vcpkg CI uses a canonical Pkg-config: No. Every port is using OpenSSL workarounds and patches. Or simply doesn't use openssl. Note that the missing file was discovered with #20556 (libnice) or more precisely for nghttp2 (#20556 (comment)). But note that this is a by-product of starting to use pkg-config files for nmake/windows in port gdal where invalid exported cmake config made its way into netcdf-c's pkg-config files, breaking the build of gdal. So this going to be part of a solid CI tested network of dependencies around gdal. I'm sure I will touch a lot of ports in that network which use hard-wired transitive dependencies at the moment. That's why I'm reluctant to add additional ports to my list. (I'm just fixing gdal's dependencies for mingw builds again.) |
|
I'd like other guys to double confirm this. |
| Name: OpenSSL-libcrypto | ||
| Description: OpenSSL cryptography library | ||
| Libs: -L"${libdir}" -llibcrypto | ||
| Libs.private: -lcrypt32 -lws2_32 |
There was a problem hiding this comment.
Doesn't MinGW need these too?
There was a problem hiding this comment.
Mingw already gets pc files, as it is using the unix branch of the port. libcrypto.pc for mingw-dynamic has:
Libs.private: -lws2_32 -lgdi32 -lcrypt32
But my change for windows is based on consuming ports.
|
Thanks for the help! |
Describe the pull request
What does your PR fix?
Install
openssl.pcfile ([openssl] Install pc files on all platforms and install openssl.pc #20563).Install pc files for Windows ([openssl] Install pc files on all platforms and install openssl.pc #20563).
Link Windows libraries by name spec without .lib suffix. Some ports (e.g. netcdf-c) put these libraries in pc files, and with --msvc-syntax, .lib added (again).
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes