[boost-modular-build-helper] Fixup mingw lib names#20576
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Oct 12, 2021
Merged
[boost-modular-build-helper] Fixup mingw lib names#20576BillyONeal merged 4 commits intomicrosoft:masterfrom
BillyONeal merged 4 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PhoebeHui
added
the
category:port-feature
PhoebeHui
added
the
info:needs-maintainer-attention
dg0yt
commented
Oct 8, 2021
| endif() | ||
| endforeach() | ||
| # Similar for mingw | ||
| file(GLOB INSTALLED_LIBS "${CURRENT_PACKAGES_DIR}/debug/lib/*-mgw10-*.a" "${CURRENT_PACKAGES_DIR}/lib/*-mgw10-*.a") |
Contributor
Author
There was a problem hiding this comment.
Other than in the regex below, the glob uses literal -mgw10-. I'm not sure what the 10 stands for. Maybe gcc version? It might be more robust to use -mgw*- instead. The regex will still limit the cases of renaming.
BillyONeal
added
the
depends:different-pr
Member
|
This change looks good but I want to make sure it builds cleanly with #20432 |
# Conflicts: # versions/b-/boost-modular-build-helper.json
Member
|
I pushed a merge with master to ensure #20432 was applied and that rerunning generate-ports resulted in no additional changes. |
BillyONeal
removed
the
depends:different-pr
BillyONeal
approved these changes
Oct 12, 2021
Member
|
Thanks for fixing MinGW! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes building boost on mingw on windows, removing all tags from the static and import lib names (
.aand.dll.a).Almost the same is already implemented for
.libnames.Which triplets are supported/not supported? Have you updated the CI baseline?
all+mingw, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes
Tested with x64-mingw-static and -dynamic on windows.