Skip to content

[qt] Fix qtmultimedia with gstreamer on windows#20555

Merged
BillyONeal merged 10 commits intomicrosoft:masterfrom
Neumann-A:fix_qtmultimedia
Oct 11, 2021
Merged

[qt] Fix qtmultimedia with gstreamer on windows#20555
BillyONeal merged 10 commits intomicrosoft:masterfrom
Neumann-A:fix_qtmultimedia

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Oct 6, 2021

~~ Why is gstreamer a cascade in CI? ~~ Becasue libnice was on the skiplist since the URL was not reachable......

Also I assumed some of these patches to be in 6.2 but they are not. They are in the dev branch but not the release branch for some reason. Maybe they will be part of 6.2.1?

closes #20530

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/qtbase/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/qtbase/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/qtbase/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/qtbase/portfile.cmake

@Neumann-A Neumann-A marked this pull request as ready for review October 7, 2021 07:04
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Oct 8, 2021
@JackBoosY JackBoosY added requires:author-response info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Oct 8, 2021
@BillyONeal BillyONeal merged commit 1d4128f into microsoft:master Oct 11, 2021
@BillyONeal
Copy link
Member

Thanks for the bugfix and usual awesome @Neumann-A :)

@Neumann-A Neumann-A deleted the fix_qtmultimedia branch October 11, 2021 18:22
@Neumann-A
Copy link
Contributor Author

@BillyONeal don't forget to have somebody fix the gstreamer:x64-osx regression

@BillyONeal
Copy link
Member

@BillyONeal don't forget to have somebody fix the gstreamer:x64-osx regression

It isn't really a regression, since it was previously not being tested.

@Neumann-A
Copy link
Contributor Author

@BillyONeal It should have been tested before libnice was put on the baseline.

@JackBoosY
Copy link
Contributor

Related PR: #20556.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qtmultimedia:x64-windows] build failure

3 participants