Skip to content

[gstreamer, gst-rtsp-server] update and add port#20474

Merged
ras0219-msft merged 6 commits intomicrosoft:masterfrom
mathisloge:gst-rtsp-server
Oct 5, 2021
Merged

[gstreamer, gst-rtsp-server] update and add port#20474
ras0219-msft merged 6 commits intomicrosoft:masterfrom
mathisloge:gst-rtsp-server

Conversation

@mathisloge
Copy link
Contributor

Describe the pull request

Updates gstreamer to latest 1.19.2 and adds gst-rtsp-server

  • Which triplets are supported/not supported? Have you updated the CI baseline?

no

yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@mathisloge mathisloge marked this pull request as ready for review October 5, 2021 19:45
@ras0219-msft ras0219-msft merged commit b9ed4c9 into microsoft:master Oct 5, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the update and new port!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Oct 5, 2021
[gstreamer, gst-rtsp-server] update and add port (microsoft#20474)
@luncliff
Copy link
Contributor

luncliff commented Feb 5, 2022

Can we run the build for this PR again?
I want to check the build log for x64-osx.
This port should fail because it requires Gstreamer's bad plugin which is not supported yet(#17394).

@dg0yt
Copy link
Contributor

dg0yt commented Feb 5, 2022

Can we run the build for this PR again?

git commit --allow-empty -m "[skip actions] CI"
git push

@dg0yt
Copy link
Contributor

dg0yt commented Feb 5, 2022

(Or merge master, and push.)

@mathisloge
Copy link
Contributor Author

mathisloge commented Feb 5, 2022

(Or merge master, and push.)

I've done this. But didnt work for merged PRs Screenshot_20220205-175122.jpg

@dg0yt
Copy link
Contributor

dg0yt commented Feb 5, 2022

But didnt work for merged PRs

Sorry, I didn't pay attention...

This port should fail because it requires Gstreamer's bad plugin

vcpkg daily CI builds gstreamer[core,plugins-good,plugins-ugly]:x64-osx. Where does it require the bad plugin?
https://dev.azure.com/vcpkg/public/_build/results?buildId=66830&view=logs&j=7b75bd19-17d3-53d4-00fd-23f1a49a8ba4&t=a23dba4e-3a62-59dc-a73c-a7222676d7a4

@luncliff
Copy link
Contributor

luncliff commented Feb 5, 2022

#22910 gst-rtsp-server was trying to find the bad plugin with pkg-config. It's not installed by port gstreamer. Eventually, gst-rtsp-server's configuration should fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants