Skip to content

[ECM] fix FindCanberra for static builds#20213

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
wrobelda:ecm_canberra_fix
Sep 17, 2021
Merged

[ECM] fix FindCanberra for static builds#20213
BillyONeal merged 4 commits intomicrosoft:masterfrom
wrobelda:ecm_canberra_fix

Conversation

@wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Sep 16, 2021

Also remove dangling do-not-override-custom-clang-format-files.patch

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ecm/portfile.cmake

@wrobelda wrobelda mentioned this pull request Sep 16, 2021
4 tasks
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Sep 17, 2021
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 17, 2021
@BillyONeal BillyONeal merged commit 57ab68d into microsoft:master Sep 17, 2021
@BillyONeal
Copy link
Member

Thanks for the fix!

@wrobelda wrobelda deleted the ecm_canberra_fix branch September 17, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants