Skip to content

[gmp] Enable C++ support on Unix #20205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillyONeal merged 2 commits into from
Sep 20, 2021
Merged

[gmp] Enable C++ support on Unix #20205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d02813
[gmp] enable C++ support
wrobelda Sep 16, 2021
e70c9fb
[gmp] update versions
wrobelda Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ports/gmp/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ else()
vcpkg_configure_make(
SOURCE_PATH ${SOURCE_PATH}
AUTOCONFIG
OPTIONS ${OPTIONS}
OPTIONS
--enable-cxx
Copy link
Contributor

@JackBoosY JackBoosY Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see that this option is a feature, not to force it here.

Copy link
Contributor Author

@wrobelda wrobelda Sep 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and given that Vcpkg is C++ first, why would the C++ bindings be optional here? Wouldn't pretty much everyone enable them anyway?

EDIT: although I just realized I can make it a feature and enable it by default.

Copy link
Contributor

@Neumann-A Neumann-A Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is rather how to deactivate it on the windows path.

Copy link
Contributor Author

@wrobelda wrobelda Sep 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Windows build compiles gmpxx by default, so if anything, this brings Unix builds in line with Windows.

)

vcpkg_install_make()
Expand Down
2 changes: 1 addition & 1 deletion ports/gmp/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "gmp",
"version-string": "6.2.1",
"port-version": 6,
"port-version": 7,
"description": "The GNU Multiple Precision Arithmetic Library",
"homepage": "https://gmplib.org",
"supports": "!(windows & (arm | arm64))",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2446,7 +2446,7 @@
},
"gmp": {
"baseline": "6.2.1",
"port-version": 6
"port-version": 7
},
"google-cloud-cpp": {
"baseline": "1.31.1",
Expand Down
5 changes: 5 additions & 0 deletions versions/g-/gmp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "5d207c0d8a6481f96f2277fd3245f2a80456a706",
"version-string": "6.2.1",
"port-version": 7
},
{
"git-tree": "645878e32f8ab4e926f605107c761433515a17dd",
"version-string": "6.2.1",
Expand Down