Skip to content

[neon2sse] create a new port#20200

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
luncliff:port/neon2sse
Sep 17, 2021
Merged

[neon2sse] create a new port#20200
BillyONeal merged 3 commits intomicrosoft:masterfrom
luncliff:port/neon2sse

Conversation

@luncliff
Copy link
Contributor

@luncliff luncliff commented Sep 16, 2021

What does your PR fix?

Add a library neon2sse. https://github.com/intel/ARM_NEON_2_x86_SSE
This project provides 1 header file and supports find_package for CMake projects.

find_package(NEON_2_SSE CONFIG REQUIRED) # NEON_2_SSE::NEON_2_SSE

Which triplets are supported/not supported? Have you updated the CI baseline?

This is a header only. So every triplet must be available.

Does your PR follow the maintainer guide?

I think so

@PhoebeHui PhoebeHui self-assigned this Sep 17, 2021
@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 17, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 17, 2021
@BillyONeal BillyONeal added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Sep 17, 2021
@luncliff
Copy link
Contributor Author

luncliff commented Sep 17, 2021 via email

@BillyONeal
Copy link
Member

Yes, I think it looks better too, but it also forces people who get this from vcpkg to use a different find_package name than the normal one upstream uses; ideally we match upstream exactly unless we have some reason we can't.

@luncliff
Copy link
Contributor Author

luncliff commented Sep 17, 2021 via email

@BillyONeal BillyONeal merged commit 4428702 into microsoft:master Sep 17, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

@luncliff luncliff deleted the port/neon2sse branch September 17, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants