[kf5kcmutils] new port by wrobelda · Pull Request #20199 · microsoft/vcpkg

wrobelda · 2021-09-16T11:47:06Z

Describe the pull request
Adds new kf5kcmutils port. Depends on:

[kf5xmlgui] New port #19756
[kf5declarative] new port #19813
[kf5declarative] shared plugins fix #20934
Which triplets are supported/not supported? Have you updated the CI baseline?

All plus arm64-osx
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I am still working on this PR

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index b568f60..b68bd56 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3020,10 +3020,6 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
-      "baseline": "5.84.0",
-      "port-version": 0
-    },
     "kf5package": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d21f89f..f8bcbe0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3024,15 +3024,15 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5notifications": {
+    "kf5kcmutils": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kcmutils": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5notifications": {
       "baseline": "5.84.0",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- New SHA: dc898926b69ad5ef32655c80d3cc2acdf47d166f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 30a3d841d88dbf1e668d875bcfc050aacdedc63b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index b58f0d8..569e694 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3024,15 +3024,15 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5kcmutils": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5notifications": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kcmutils": {
+    "kf5notifications": {
       "baseline": "5.84.0",
       "port-version": 0
     },

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/kf5bookmarks/portfile.cmake
ports/kf5declarative/portfile.cmake
ports/kf5kcmutils/portfile.cmake
ports/kf5kio/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/kf5xmlgui/portfile.cmake
ports/libcanberra/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 574c125d6f1dd8150dadf1e116cd182823591626 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 93ef80a..b4fa0ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3024,15 +3024,15 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5kcmutils": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5notifications": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kcmutils": {
+    "kf5notifications": {
       "baseline": "5.84.0",
       "port-version": 0
     },

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/kf5bookmarks/portfile.cmake
ports/kf5declarative/portfile.cmake
ports/kf5kcmutils/portfile.cmake
ports/kf5kio/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/kf5xmlgui/portfile.cmake
ports/libcanberra/portfile.cmake
ports/openimageio/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 2297273..8921907 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3024,11 +3024,11 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kio": {
+    "kf5kcmutils": {
       "baseline": "5.84.0",
       "port-version": 0
     },
-    "kf5kcmutils": {
+    "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
     },
diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 53233ef..513047f 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -6,8 +6,8 @@
       "port-version": 1
     },
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/kf5bookmarks/portfile.cmake
ports/kf5declarative/portfile.cmake
ports/kf5kcmutils/portfile.cmake
ports/kf5kio/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/kf5xmlgui/portfile.cmake
ports/libcanberra/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 33f02c0ae50c262da487d21ace4f5d67ae949c18 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index dbf33c0..0fb2914 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3012,14 +3012,14 @@
       "baseline": "5.84.0",
       "port-version": 2
     },
-    "kf5diagram": {
-      "baseline": "2.8.0",
-      "port-version": 0
-    },
     "kf5declarative": {
       "baseline": "5.84.0",
       "port-version": 0
     },
+    "kf5diagram": {
+      "baseline": "2.8.0",
+      "port-version": 0
+    },
     "kf5globalaccel": {
       "baseline": "5.84.0",
       "port-version": 1
@@ -3052,6 +3052,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5kcmutils": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
@@ -3064,10 +3068,6 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5kcmutils": {
-      "baseline": "5.84.0",
-      "port-version": 0
-    },
     "kf5plotting": {
       "baseline": "5.84.0",
       "port-version": 2

wrobelda · 2021-10-22T10:47:09Z

@NancyLi1013 no longer has dependencies, should be good to go.

EDIT: new dependency to fix static Windows builds: #20934

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 2169ab765b49cfc5cd7eddfc8ff3e579326776f8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 55dc1ee..80eb459 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3080,6 +3080,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5kcmutils": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5kio": {
       "baseline": "5.84.0",
       "port-version": 0
@@ -3096,10 +3100,6 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
-    "kf5kcmutils": {
-      "baseline": "5.84.0",
-      "port-version": 0
-    },
     "kf5plotting": {
       "baseline": "5.84.0",
       "port-version": 2

wrobelda · 2021-10-27T06:57:54Z

@NancyLi1013 the PR no longer has dependencies, good to go!

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout f2edf8010273c0bf0ff97285dc161ba4137d46bf -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/i-/icu.json b/versions/i-/icu.json
index 7f106d5..17f2df3 100644
--- a/versions/i-/icu.json
+++ b/versions/i-/icu.json
@@ -1,5 +1,30 @@
 {
   "versions": [
+    {
+      "git-tree": "2d08c0ceb1777074f3b31fe51e386c9ece0ca8cd",
+      "version": "69.1",
+      "port-version": 15
+    },
+    {
+      "git-tree": "2632dd55c20f6830027ae1e167524817b1a9d7ec",
+      "version": "69.1",
+      "port-version": 14
+    },
+    {
+      "git-tree": "d8c36cdfe8059aadefd80b2d5800a5d9f3494cd6",
+      "version": "69.1",
+      "port-version": 13
+    },
+    {
+      "git-tree": "02bcc079d00e16237aa0d1af449d7663581a1525",
+      "version": "69.1",
+      "port-version": 12
+    },
+    {
+      "git-tree": "46d639d2e138f9ee3362fd8023f64463ae4e6afa",
+      "version": "69.1",
+      "port-version": 11
+    },
     {
       "git-tree": "07e8fca3896a13ac7b4196e104015174429a6c74",
       "version": "69.1",

ports/icu/portfile.cmake

ports/icu/vcpkg.json

ports/kf5kcmutils/fix_cmake_config.patch

versions/i-/icu.json

wrobelda force-pushed the kf5kcmutils branch from 5225043 to bd7d1b1 Compare September 16, 2021 11:50

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

github-actions bot requested changes Sep 16, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from bd7d1b1 to 9cf309e Compare September 16, 2021 11:51

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

github-actions bot requested changes Sep 16, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from 5214098 to eebcfbd Compare September 16, 2021 22:43

github-actions bot requested changes Sep 16, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from eebcfbd to 6ff060e Compare September 17, 2021 01:04

github-actions bot requested changes Sep 17, 2021

View reviewed changes

PhoebeHui assigned NancyLi1013 Sep 17, 2021

NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Sep 17, 2021

wrobelda force-pushed the kf5kcmutils branch from 6ff060e to cedd4be Compare September 17, 2021 12:55

github-actions bot requested changes Sep 17, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch 2 times, most recently from 5022cb8 to 22704ab Compare September 17, 2021 17:12

github-actions bot approved these changes Sep 20, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from b7e991d to 6be22e2 Compare September 23, 2021 13:48

github-actions bot approved these changes Sep 23, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from 6be22e2 to a8b017d Compare September 29, 2021 15:04

github-actions bot requested changes Sep 29, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from a8b017d to 20c48cd Compare October 22, 2021 10:46

wrobelda marked this pull request as ready for review October 22, 2021 10:47

github-actions bot requested changes Oct 22, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from 20c48cd to e7a9c2a Compare October 22, 2021 11:03

github-actions bot approved these changes Oct 22, 2021

View reviewed changes

wrobelda force-pushed the kf5kcmutils branch from e7a9c2a to 5757e02 Compare October 22, 2021 11:09

github-actions bot approved these changes Oct 22, 2021

View reviewed changes

wrobelda mentioned this pull request Oct 24, 2021

[kf5*] Update to 5.87 #20938

Merged

3 tasks

wrobelda force-pushed the kf5kcmutils branch from 6dd50d3 to 74feb62 Compare October 27, 2021 06:57

github-actions bot requested changes Oct 27, 2021

View reviewed changes

NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 27, 2021

NancyLi1013 suggested changes Oct 27, 2021

View reviewed changes

NancyLi1013 added the requires:author-response label Oct 27, 2021

wrobelda and others added 12 commits October 27, 2021 14:49

Add kf5kcmutils port

5811c1a

Fixed kf5kcmutils for windows

aba8908

[kf5*] update to 5.75.0

2f441f8

[kf5kcmutils] update to latest spec

f03e817

[kf5kcmutils] use semVer

2844754

[kf5kcmutils] add PACKAGE_NAME to vcpkg_cmake_config_fixup

86eb60e

[kf5kcmutils] update to 5.84.0

c7ade1b

[kf5kcmutils] fix versioning scheme

10b3e3a

[kf5kcmutils] fix SHA sum

429f63b

[kf5kcmutils] fix cmake config for static builds

3325003

[kf5kcmutils] add gettext tools dependency

b9f7e0a

[kf5kcmutils] update versions

25832be

wrobelda force-pushed the kf5kcmutils branch from 74feb62 to 25832be Compare October 27, 2021 12:49

github-actions bot approved these changes Oct 27, 2021

View reviewed changes

wrobelda added 2 commits October 27, 2021 14:51

[kf5kcmutils] reduce patch size

873a1e0

[kf5kcmutils] update versions

af5095e

github-actions bot approved these changes Oct 27, 2021

View reviewed changes

NancyLi1013 approved these changes Oct 28, 2021

View reviewed changes

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Oct 28, 2021

dan-shaw merged commit f260814 into microsoft:master Oct 28, 2021

wrobelda deleted the kf5kcmutils branch October 28, 2021 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kf5kcmutils] new port#20199

[kf5kcmutils] new port#20199
dan-shaw merged 14 commits intomicrosoft:masterfrom
wrobelda:kf5kcmutils

wrobelda commented Sep 16, 2021 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

wrobelda commented Oct 22, 2021 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

wrobelda commented Oct 27, 2021 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wrobelda commented Sep 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

wrobelda commented Oct 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

wrobelda commented Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wrobelda commented Sep 16, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

wrobelda commented Oct 22, 2021 •

edited

Loading

wrobelda commented Oct 27, 2021 •

edited

Loading