Skip to content

[discord-game-sdk] use updated domain name#20153

Merged
BillyONeal merged 9 commits intomicrosoft:masterfrom
J-Human:discord-game-sdk/use-newer-domain
Sep 17, 2021
Merged

[discord-game-sdk] use updated domain name#20153
BillyONeal merged 9 commits intomicrosoft:masterfrom
J-Human:discord-game-sdk/use-newer-domain

Conversation

@J-Human
Copy link
Contributor

@J-Human J-Human commented Sep 14, 2021

Describe the pull request
This updates the external URLs to use the base domain name of discord instead of discordapp since the company changed the name last year.

  • What does your PR fix?

N/A

  • Which triplets are supported/not supported? Have you updated the CI baseline?

As per the configuration file, all 3 are supported. No, I didn't.

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Done.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
N/A

@NancyLi1013
Copy link
Contributor

Please run vcpkg x-add-version discord-game-sdk to update version files after you address the review suggestions.

@J-Human
Copy link
Contributor Author

J-Human commented Sep 15, 2021

Please run vcpkg x-add-version discord-game-sdk to update version files after you address the review suggestions.

Done, it has been committed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/d-/discord-game-sdk.json b/versions/d-/discord-game-sdk.json
index be83021..d1768f1 100644
--- a/versions/d-/discord-game-sdk.json
+++ b/versions/d-/discord-game-sdk.json
@@ -6,7 +6,7 @@
       "port-version": 3
     },
     {
-      "git-tree": "1e36656365b603448365695d858cf2eaf3aff0bd",
+      "git-tree": "17cdcbe9e20da2ed085fc2de181ae426d62f2609",
       "version-string": "2.5.6",
       "port-version": 2
     },

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/d-/discord-game-sdk.json b/versions/d-/discord-game-sdk.json
index be83021..d1768f1 100644
--- a/versions/d-/discord-game-sdk.json
+++ b/versions/d-/discord-game-sdk.json
@@ -6,7 +6,7 @@
       "port-version": 3
     },
     {
-      "git-tree": "1e36656365b603448365695d858cf2eaf3aff0bd",
+      "git-tree": "17cdcbe9e20da2ed085fc2de181ae426d62f2609",
       "version-string": "2.5.6",
       "port-version": 2
     },

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 17, 2021
@BillyONeal BillyONeal merged commit 03b5beb into microsoft:master Sep 17, 2021
@BillyONeal
Copy link
Member

Looks good, thank you!

@J-Human J-Human deleted the discord-game-sdk/use-newer-domain branch September 18, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants