[discord-game-sdk] use updated domain name#20153
[discord-game-sdk] use updated domain name#20153BillyONeal merged 9 commits intomicrosoft:masterfrom J-Human:discord-game-sdk/use-newer-domain
Conversation
|
Please run |
Done, it has been committed. |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/d-/discord-game-sdk.json b/versions/d-/discord-game-sdk.json
index be83021..d1768f1 100644
--- a/versions/d-/discord-game-sdk.json
+++ b/versions/d-/discord-game-sdk.json
@@ -6,7 +6,7 @@
"port-version": 3
},
{
- "git-tree": "1e36656365b603448365695d858cf2eaf3aff0bd",
+ "git-tree": "17cdcbe9e20da2ed085fc2de181ae426d62f2609",
"version-string": "2.5.6",
"port-version": 2
},There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/d-/discord-game-sdk.json b/versions/d-/discord-game-sdk.json
index be83021..d1768f1 100644
--- a/versions/d-/discord-game-sdk.json
+++ b/versions/d-/discord-game-sdk.json
@@ -6,7 +6,7 @@
"port-version": 3
},
{
- "git-tree": "1e36656365b603448365695d858cf2eaf3aff0bd",
+ "git-tree": "17cdcbe9e20da2ed085fc2de181ae426d62f2609",
"version-string": "2.5.6",
"port-version": 2
},Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/ffnvcodec/portfile.cmakeports/libproxy/portfile.cmake
|
Looks good, thank you! |
Describe the pull request
This updates the external URLs to use the base domain name of
discordinstead ofdiscordappsince the company changed the name last year.What does your PR fix?
N/A
Which triplets are supported/not supported? Have you updated the CI baseline?
As per the configuration file, all 3 are supported. No, I didn't.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Done.
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
N/A