[vtk] Add feature gdal and geojson, re-factory the feature select part#20147
Merged
BillyONeal merged 8 commits intomicrosoft:masterfrom Oct 11, 2021
Merged
[vtk] Add feature gdal and geojson, re-factory the feature select part#20147BillyONeal merged 8 commits intomicrosoft:masterfrom
BillyONeal merged 8 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-feature
Contributor
Author
|
@embeddedmz Does this meet you requirement? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e201002b4f4827d7b7b672f0c5c672a77fc3b77d -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 03050a4..08f076b 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6774,7 +6774,7 @@
},
"vtk": {
"baseline": "9.0.3-pv5.9.1",
- "port-version": 1
+ "port-version": 2
},
"vtk-dicom": {
"baseline": "0.8.12",
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 5b67419..78bec86 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "120926c414d59bf84f65b2e48a05336b0e44e757",
+ "version-semver": "9.0.3-pv5.9.1",
+ "port-version": 2
+ },
{
"git-tree": "413d7fcbff9b50e57e486d1249c841a5e25c0def",
"version-semver": "9.0.3-pv5.9.1",
Neumann-A
reviewed
Sep 14, 2021
Neumann-A
reviewed
Sep 14, 2021
|
@JackBoosY So with this pull request, I can download VTK's GDAL and GeoJSON modules ? |
Contributor
Author
|
@embeddedmz Yeah, please use feature |
|
@JackBoosY I didn't find them when using search (and I ran git pull). Do I have to install vtk[all] ? |
|
I'm having issues installing VTK or VTK[ALL] : |
Contributor
Author
|
@embeddedmz You need to use my branch. |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e201002b4f4827d7b7b672f0c5c672a77fc3b77d -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 78bec86..9d38298 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "120926c414d59bf84f65b2e48a05336b0e44e757",
+ "git-tree": "256bd4adc7d8f7827b8dd39f540c2f0f21bd5f94",
"version-semver": "9.0.3-pv5.9.1",
"port-version": 2
},
|
@JackBoosY I always have this error when attempting to install new modules (HDF5/MPI issue) : Below, the content of "D:\vcpkg\buildtrees\vtk\config-x64-windows-out.log" : |
Contributor
Author
|
@embeddedmz Please pull the latest code. |
|
@JackBoosY I have already pulled the commit "Fix feature option MPI". I am installing vtk[mpi] right now (Neumann deleted comment gave me that hint). Maybe after installing it, that will fix the issue (that's strange because I tried to install vtk[all] that includes MPI and I got the error related to MPI, maybe there's an order issue. |
|
I have this error now : |
Contributor
Author
|
Contributor
|
Well, I fixed a lot in the exported pkgconfig files of gdal's dependencies (non-windows). But there is huge gap left: I think what we need first is a maintainable way how to transfer usage requirements along msbuild dependency chains. (It is not just gdal.) Options are:
(Side note: It is an issue not just for ports using msbuild. Port qt5-base is build around |
Contributor
Sorry, this is mostly not valid. I also update the vcpkg cmake wrapper. So usage in CMake should be mostly okay. But there is one dangerous thing about are vcpkg's wrappers: Putting debug/release variants in the
|
Contributor
|
|
Contributor
|
@dg0yt : vcpkg/ports/qt5-base/portfile.cmake Line 231 in 4428702
This just needs to be fixed downstream. |
Contributor
Which may mean: in the user's project. |
Contributor
Taking this as a vote for pc files regarding my three options for improving port gdal (msbuild). I'm fine with that, even it means adding pc files to other msbuild ports. |
Contributor
Author
|
Since there is no dependency graph, I have to test individual features one by one, this is not good. |
Contributor
Author
|
@embeddedmz Please pull the latest changes and try again. Thanks. |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e201002b4f4827d7b7b672f0c5c672a77fc3b77d -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 78bec86..6a6cd0b 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "120926c414d59bf84f65b2e48a05336b0e44e757",
+ "git-tree": "8a6faf67b7c7d4e3fba1f888817e3a18f80837b1",
"version-semver": "9.0.3-pv5.9.1",
"port-version": 2
},You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/vtk/portfile.cmake
added 2 commits
September 27, 2021 22:48
|
@JackBoosY OK I will do it next monday and will give you a feedback. Thanks. |
|
@JackBoosY It's OK for me ! Thank you for your efforts ! |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
October 7, 2021 22:53
PhoebeHui
approved these changes
Oct 9, 2021
PhoebeHui
added
the
info:needs-maintainer-attention
Member
I believe that as long as we have "use the upstream build system wherever possible" as a core design ideal anything like that is going to be difficult. MSBuild just doesn't have the ability to handle transitive dependencies like this :( |
Member
|
Thanks for the features! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
Since the option value of cmake feature in vtk should be
YESorDONT_WANT, use vcpkg_check_features and switchON/OFFtoYES/DONT_WANT.Fixes #20129.
All features are tested in
x64-windows,x64-windows-staticandx64-linux.