Skip to content

[log4cxx] Update to 0.12.0#19963

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/19914
Oct 15, 2021
Merged

[log4cxx] Update to 0.12.0#19963
vicroms merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/19914

Conversation

@JackBoosY
Copy link
Contributor

Update to 0.12.0 and re-generate patches.

Fixes #19914 maybe fix #19730.

@JackBoosY JackBoosY added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Sep 3, 2021
@JackBoosY
Copy link
Contributor Author

Hi @SergeiDelov, does this update fix your issue?

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

@strega-nil-ms Do you know why the gz file extract failed?

  1 CMake Error: Problem with archive_read_next_header(): Pathname can't be converted from UTF-8 to current locale.
  2 CMake Error: Problem extracting tar: /Users/vcpkg/Documents/vcpkg/downloads/apache-log4cxx-0.12.0.tar.gz

@strega-nil-ms
Copy link
Contributor

@JackBoosY I have no idea... I guess it's because the tarball has a non-ASCII pathname, but that should be supported...

@rm5248
Copy link

rm5248 commented Sep 8, 2021

If the problem is with files under src/test/resources/output, those can be ignored - that folder was incorrectly added to the distribution. Those files are output data from the unit tests.

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Sep 8, 2021
@JackBoosY
Copy link
Contributor Author

Use command tar xzvf result: pass.

@JackBoosY
Copy link
Contributor Author

Maybe related to these file:
src\test\resources\output\dom³
src\test\resources\output\dom㆕
src\test\resources\output\PaxHeader\dom³
src\test\resources\output\PaxHeader\dom㆕

@strega-nil-ms
Copy link
Contributor

@JackBoosY yeah, the issue is that the locale is set to "C", which is apparently not treated as utf-8; the fix here is to fix the CI, since we can't in general set the locale to a utf-8 locale.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 26, 2021
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/log4cxx/portfile.cmake

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 13, 2021
@JackBoosY JackBoosY requested a review from NancyLi1013 October 14, 2021 02:26
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 14, 2021
@vicroms vicroms merged commit 781c621 into microsoft:master Oct 15, 2021
@JackBoosY JackBoosY deleted the dev/jack/19914 branch October 15, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[log4cxx] update to 0.12.0 [log4cxx] failure to compile application with clang on Windows/VC2019

5 participants