[libcanberra] new port#19816
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 39630f5..2f96fe5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3112,6 +3112,10 @@
"baseline": "1.16.1",
"port-version": 2
},
+ "libcanberra": {
+ "baseline": "0.30",
+ "port-version": 0
+ },
"libcbor": {
"baseline": "0.8.0",
"port-version": 0There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libcanberra but no changes to version or port version.
-- Version: 0.30
-- Old SHA: fbbdc377caacd33ccd99189d5aebf62f3a44de12
-- New SHA: ef18fe1c336a2eae916fc8a89b7ebe18b7042ce7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
7975912 to
85bcec1
Compare
a208f75 to
c6ce116
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@PhoebeHui FYI this currently rebuilds the world due to #19852, which this PR depends on. |
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/libcanberra/portfile.cmake
diff --git a/ports/libcanberra/portfile.cmake b/ports/libcanberra/portfile.cmake index 1dec621..b4d75f7 100644 --- a/ports/libcanberra/portfile.cmake +++ b/ports/libcanberra/portfile.cmake @@ -62,7 +62,6 @@ if(VCPKG_TARGET_IS_OSX) endif() vcpkg_fixup_pkgconfig() -vcpkg_copy_pdbs() file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share") file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/tools") # empty folder
476b0af to
79733f8
Compare
|
@PhoebeHui this no longer has any dependencies, ready to be merged. |
PhoebeHui
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
|
Thanks for the new port! |
Describe the pull request
Adds new libcanberra port.
Depends on:
[vcpkg_fixup_pkgconfig] Add support for Cflags.private #19852
Which triplets are supported/not supported? Have you updated the CI baseline?
Linux and macOS only.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes