[activemq-cpp] support linux#19789
Merged
BillyONeal merged 51 commits intomicrosoft:masterfrom Oct 11, 2021
mheyman:activemq-cpp
Merged
[activemq-cpp] support linux#19789BillyONeal merged 51 commits intomicrosoft:masterfrom mheyman:activemq-cpp
BillyONeal merged 51 commits intomicrosoft:masterfrom
mheyman:activemq-cpp
Conversation
find_library() and find_file() were waaaaay too snazzy and would sometimes pull in things from outside where we want. _set_if_exists() just sets the variable if the file exists.
Make it a little bit harder to mistype repeated strings.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/activemq-cpp.json b/versions/a-/activemq-cpp.json
index dc33e08..3176ca6 100644
--- a/versions/a-/activemq-cpp.json
+++ b/versions/a-/activemq-cpp.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "f13857af718ef4665470f96c8bfe6efc70c59f40",
+ "git-tree": "1595a6fdc4747c40f56acf120749f5513924eefa",
"version-string": "3.9.5-3",
"port-version": 1
},
BillyONeal
reviewed
Sep 24, 2021
BillyONeal
reviewed
Sep 24, 2021
BillyONeal
requested changes
Sep 24, 2021
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
- I think we need a discussion about unofficial being in the namespace
- Spelling and version changes?
BillyONeal
added
requires:author-response
and removed
info:needs-maintainer-attention
JackBoosY
removed
the
requires:vcpkg-team-review
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2a31089e777fc187f1cc05338250b8e1810cfb52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/activemq-cpp.json b/versions/a-/activemq-cpp.json
index 8a333f81..97d25026 100644
--- a/versions/a-/activemq-cpp.json
+++ b/versions/a-/activemq-cpp.json
@@ -6,8 +6,8 @@
"port-version": 5
},
{
- "git-tree": "a79e889b8aebba750fc6fdb78a6ddba979d73c29",
- "version-semver": "3.9.5",
+ "git-tree": "13f5f938c4d12bf4a62061f9891f77e7fc03fc23",
+ "version-string": "3.9.5",
"port-version": 4
},
{
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2a31089e777fc187f1cc05338250b8e1810cfb52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/activemq-cpp.json b/versions/a-/activemq-cpp.json
index a47d433c..50f74c26 100644
--- a/versions/a-/activemq-cpp.json
+++ b/versions/a-/activemq-cpp.json
@@ -1,13 +1,13 @@
{
"versions": [
{
- "git-tree": "bc98d3ab1ce19b270f11800fc522673c70b00c53",
+ "git-tree": "7753795446222a0cd7eca866a1949ad6e03e2463",
"version-semver": "3.9.5",
"port-version": 5
},
{
- "git-tree": "a79e889b8aebba750fc6fdb78a6ddba979d73c29",
- "version-semver": "3.9.5",
+ "git-tree": "13f5f938c4d12bf4a62061f9891f77e7fc03fc23",
+ "version-string": "3.9.5",
"port-version": 4
},
{
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2a31089e777fc187f1cc05338250b8e1810cfb52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/activemq-cpp.json b/versions/a-/activemq-cpp.json
index 78795822..50f74c26 100644
--- a/versions/a-/activemq-cpp.json
+++ b/versions/a-/activemq-cpp.json
@@ -6,8 +6,8 @@
"port-version": 5
},
{
- "git-tree": "a79e889b8aebba750fc6fdb78a6ddba979d73c29",
- "version-semver": "3.9.5",
+ "git-tree": "13f5f938c4d12bf4a62061f9891f77e7fc03fc23",
+ "version-string": "3.9.5",
"port-version": 4
},
{
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2a31089e777fc187f1cc05338250b8e1810cfb52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/activemq-cpp.json b/versions/a-/activemq-cpp.json
index 50be8e91..e0832092 100644
--- a/versions/a-/activemq-cpp.json
+++ b/versions/a-/activemq-cpp.json
@@ -6,8 +6,8 @@
"port-version": 5
},
{
- "git-tree": "a79e889b8aebba750fc6fdb78a6ddba979d73c29",
- "version-semver": "3.9.5",
+ "git-tree": "13f5f938c4d12bf4a62061f9891f77e7fc03fc23",
+ "version-string": "3.9.5",
"port-version": 4
},
{
BillyONeal
approved these changes
Oct 6, 2021
PhoebeHui
approved these changes
Oct 8, 2021
PhoebeHui
added
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for linux and x64-windows-static-md in the
activemq-cppport.It also adds an
activemq-cppConfig.cmakefile for integration with CMake'sfind_package(activemq-cpp)call. This may only work on Linux and Windows (the only place I could test). I hope the Linux case works on other platforms too. That file might have got a little larger than I expected it to be when I started :-) and there might be some opportunity for cleanup but I'm not enough of a CMake wizard to know a better way to go about supporting Linux and Windows in shared and static builds than brute force.Which triplets are supported/not supported? Have you updated the [CI baseline]
All (I hope...we'll see).
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
Yes./vcpkg x-add-version --alland committed the result?