Skip to content

[vcpkg/msbuild] parellel build #19718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillyONeal merged 9 commits into from
Sep 30, 2021
Merged

[vcpkg/msbuild] parellel build #19718

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b4c35e7
[vcpkg/msbuild] parellel build
Aug 23, 2021
73ac96b
[vcpkg/msbuild] respects VCPKG_MAX_CONCURRENCY
mheyman Aug 24, 2021
967f000
[vcpkg/msbuild] handle unset VCPKG_MAX_CONCURRENCY
mheyman Aug 24, 2021
9c93023
[vcpkg/msbuild] uses VCPKG_CONCURRENCY
mheyman Aug 24, 2021
d209e4d
[vcpkg/msbuild] MultiProcMaxCount=...
mheyman Aug 24, 2021
e0cd505
[vcpkg/msbuild] EnforceProcessCountAcrossBuilds
mheyman Aug 24, 2021
f46f31b
[vcpkg/msbuild] no missing )
mheyman Aug 24, 2021
3c30343
[vcpkg/msbuild] no extra ' 's
mheyman Aug 24, 2021
cafbff9
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/cmake/vcpkg_install_msbuild.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,10 @@ function(vcpkg_install_msbuild)
"/p:VcpkgTriplet=${TARGET_TRIPLET}"
"/p:VcpkgInstalledDir=${_VCPKG_INSTALLED_DIR}"
"/p:VcpkgManifestInstall=false"
"/m"
"/p:UseMultiToolTask=true"
Copy link
Member

@BillyONeal BillyONeal Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What effect does this have, if any, for older Visual Studios without MultiToolTask?

"/p:MultiProcMaxCount=${VCPKG_CONCURRENCY}"
"/p:EnforceProcessCountAcrossBuilds=true"
"/m:${VCPKG_CONCURRENCY}"
)

if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
Expand Down