Skip to content

[vcpkg-tool] Auto update sha512#19679

Closed
autoantwort wants to merge 2 commits intomicrosoft:masterfrom
autoantwort:auto-update-sha512
Closed

[vcpkg-tool] Auto update sha512#19679
autoantwort wants to merge 2 commits intomicrosoft:masterfrom
autoantwort:auto-update-sha512

Conversation

@autoantwort
Copy link
Contributor

@PhoebeHui PhoebeHui self-assigned this Aug 23, 2021
@PhoebeHui PhoebeHui added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Aug 23, 2021
@ras0219-msft ras0219-msft requested review from strega-nil-ms and removed request for strega-nil-ms September 9, 2021 18:18
@ras0219-msft ras0219-msft removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 9, 2021
@PhoebeHui
Copy link
Contributor

@strega-nil-ms, could you please take a look again?

@PhoebeHui
Copy link
Contributor

The review suggestions has been addressed, need @strega-nil-ms @strega-nil futher review.

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 11, 2021
@BillyONeal BillyONeal removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 11, 2021
@BillyONeal
Copy link
Member

This seems OK but dropping info:reviewed as it really must be looked at in concert with microsoft/vcpkg-tool#166 as I believe this is somewhat controversial.

@PhoebeHui PhoebeHui added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 15, 2021
@wrobelda wrobelda mentioned this pull request Oct 22, 2021
3 tasks
@wrobelda wrobelda mentioned this pull request Dec 13, 2021
@PhoebeHui PhoebeHui marked this pull request as draft December 17, 2021 02:13
@JackBoosY
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please ping me to reopen if work is still being done.

@JackBoosY JackBoosY closed this Sep 16, 2022
@JackBoosY
Copy link
Contributor

Needs to wait for microsoft/vcpkg-tool#166 merge first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants