[scripts-audit] minor vcpkg_from_* fixes

[strega-nil]

Fixes #19651

Fixes an issue reported by @Neumann-A

[Neumann-A]

closes #19656

[strega-nil-ms]

cc @Neumann-A for re-review

[cenit]

what about an e2e test for a small port downloaded using --head?

[Neumann-A]

Would also like to see tests for this. E.g. a port which always calls vcpkg_from_ with two different urls and fetch_ref with --head and without --head to avoid such problems in the future.

[Neumann-A]

There seems to be another bug. My Qt6 update script nolonger works:
Error:
fatal: not a tree object: a3d8d79fbdb776f8848cba2d721ee89c28cf2e50

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: "C:/Program Files/Git/mingw64/bin/git.exe" archive a3d8d79fbdb776f8848cba2d721ee89c28cf2e50 -o E:/vcpkg_cache/downloads/temp/qtbase-v6.2.0-beta3.tar.gz
    Working Directory: E:/vcpkg_cache/downloads/git-tmp
    Error code: 128
    See logs for more information:
      E:\qt6-update\buildtrees\qtbase\git-archive-err.log

From the repo:
tag name v6.2.0-beta3 (a3d8d79fbdb776f8848cba2d721ee89c28cf2e50); tagged object commit ff31815659...

[strega-nil-ms]

@Neumann-A yep, thanks!

[Neumann-A]

@strega-nil-ms seems to work now

[sylveon]

Installing --head packages used to work if patches didn't apply to the HEAD commit. When this branch is checked out and used, patches that don't apply fail to install even with --head.

[strega-nil-ms]

@sylveon when did that work? I don't see a time in the history where this worked.

[sylveon]

I can't pinpoint an exact time, but I used to be able to do vcpkg install --head detours despite the patch not applying correctly on latest HEAD for a while.

[sylveon]

It worked back on July 7th: https://dev.azure.com/sylve0n/TranslucentTB/_build/results?buildId=140&view=logs&j=adc611be-d2d6-58a9-dbb6-278cbdb63baf&t=8cc718aa-4559-5f95-5b2c-3aeac298898c

The patch was already broken prior to that, and no new commit to the Detours repo since then would have broken it (if it wasn't already).

[strega-nil-ms]

@sylveon even back to 2018, we patched head versions (and did not pass QUIET to vcpkg_apply_patches)... so it's weird that it worked.

edit: ah yup! we added a SKIP_PATCH_CHECK to vcpkg_from_github at some point.

[strega-nil-ms]

@sylveon thanks for pointing that out!

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[cenit]

@strega-nil @strega-nil-ms @BillyONeal ping

[BillyONeal]

Thanks for tests!

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• scripts/test_ports/vcpkg-from-git-test/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• scripts/test_ports/vcpkg-from-git-test/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• scripts/test_ports/vcpkg-from-git-test/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• scripts/test_ports/vcpkg-from-git-test/vcpkg.json

Valid values for the license field can be found in the documentation

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[strega-nil-ms]

baruch hashem! finally merged @Neumann-A