[ogre] Fix include path in usage#19520
Conversation
NancyLi1013
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/o-/ogre.json b/versions/o-/ogre.json
index c25ea69..796f980 100644
--- a/versions/o-/ogre.json
+++ b/versions/o-/ogre.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "19babe49543ff790585bbc026326fe05446f9ea7",
+ "git-tree": "9c35ef4f5b30d305e6a128f9531692a64eae1b4a",
"version-semver": "1.12.9",
"port-version": 6
},
NancyLi1013
added
the
depends:different-pr
|
Depends on #19633 |
JackBoosY
removed
the
depends:different-pr
NancyLi1013
added
the
info:needs-maintainer-attention
| @@ -65,7 +61,6 @@ vcpkg_configure_cmake( | |||
| -DOGRE_BUILD_RENDERSYSTEM_D3D11=ON | |||
| -DOGRE_BUILD_RENDERSYSTEM_GL=ON | |||
| -DOGRE_BUILD_RENDERSYSTEM_GL3PLUS=ON | |||
There was a problem hiding this comment.
Why did you remove:
-DOGRE_BUILD_RENDERSYSTEM_GLES=OFF
?
There was a problem hiding this comment.
Since this option doesn't exist on the current source codes.
| endforeach() | ||
| endif() | ||
|
|
||
| vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/OGRE/Bites/OgreSGTechniqueResolverListener.h" "OgreRTShaderSystem.h" "../RTShaderSystem/OgreRTShaderSystem.h") |
There was a problem hiding this comment.
This looks like a bug in upstream, has it been reported there?
There was a problem hiding this comment.
Also it seems unlikely that this is the only header affected; in the issue report the user says that they would have to edit "hundreds of header files", not only this one. I'm not positive what the correct fix is but I don't think this is.
There was a problem hiding this comment.
Thanks for pointing this out. Since this only affects the usage in the project. I'm not sure if this is a upstream bug. In user's project sample, there is only one place that needs to update. For other header files, it is due to the user didn't include the header path correctly in his project.
The same kinds of problem may be also in other header files. I also have no better way to solve this. I'll report this problem to upstream.
BillyONeal
added
requires:author-response
and removed
info:needs-maintainer-attention
BillyONeal
added
depends:upstream-changes
|
Closing this PR since this is described as expected behavior by Ogre maintainers. It's unnecessary to handle this in vcpkg side now. Please see OGRECave/ogre#2172 (comment) and OGRECave/ogre#2172 (comment). |
3 participants
Describe the pull request
What does your PR fix?
Fixes [ogre] Cannot open include file #15333
Replace #include "OgreRTShaderSystem.h" as #include "../RTShaderSystem/OgreRTShaderSystem.h" in ../Bites/OgreSGTechniqueResolverListener.h file.
Note: No need to test features.