[kf5windowsystem] fix cmake.in for static usage; extra fixes#19440
Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom Aug 19, 2021
Merged
[kf5windowsystem] fix cmake.in for static usage; extra fixes#19440ras0219-msft merged 4 commits intomicrosoft:masterfrom
ras0219-msft merged 4 commits intomicrosoft:masterfrom
Conversation
e0b337b to
2121ced
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5windowsystem but no changes to version or port version.
-- Version: 5.84.0#1
-- Old SHA: 719b81cebad63502bbb619781290844c586acef9
-- New SHA: 5f78206cf77d0ca151e367199ed0443dd45532b1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/k-/kf5windowsystem.json b/versions/k-/kf5windowsystem.json
index 04bc1e4..091e5c1 100644
--- a/versions/k-/kf5windowsystem.json
+++ b/versions/k-/kf5windowsystem.json
@@ -1,8 +1,8 @@
{
"versions": [
{
- "git-tree": "5f78206cf77d0ca151e367199ed0443dd45532b1",
- "version-semver": "5.84.0",
+ "git-tree": "719b81cebad63502bbb619781290844c586acef9",
+ "version": "5.84.0",
"port-version": 1
},
{There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5windowsystem but no changes to version or port version.
-- Version: 5.84.0#1
-- Old SHA: 719b81cebad63502bbb619781290844c586acef9
-- New SHA: c9b5cbae7c21fcde752f9973f5dafabd896111f4
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/k-/kf5windowsystem.json b/versions/k-/kf5windowsystem.json
index cdfae26..091e5c1 100644
--- a/versions/k-/kf5windowsystem.json
+++ b/versions/k-/kf5windowsystem.json
@@ -1,8 +1,8 @@
{
"versions": [
{
- "git-tree": "c9b5cbae7c21fcde752f9973f5dafabd896111f4",
- "version-semver": "5.84.0",
+ "git-tree": "719b81cebad63502bbb619781290844c586acef9",
+ "version": "5.84.0",
"port-version": 1
},
{2121ced to
5342845
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/k-/kf5windowsystem.json b/versions/k-/kf5windowsystem.json
index 505c2c4..db56ed7 100644
--- a/versions/k-/kf5windowsystem.json
+++ b/versions/k-/kf5windowsystem.json
@@ -6,8 +6,8 @@
"port-version": 2
},
{
- "git-tree": "c9b5cbae7c21fcde752f9973f5dafabd896111f4",
- "version-semver": "5.84.0",
+ "git-tree": "719b81cebad63502bbb619781290844c586acef9",
+ "version": "5.84.0",
"port-version": 1
},
{5342845 to
dd06eba
Compare
- apply https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/27 patch - fix MAYBE_UNUSED_VARIABLES usage - use semVer - update deprecated functions - wrap paths in quotes - don't overzealously remove folders
dd06eba to
d0774ac
Compare
JackBoosY
suggested changes
Aug 9, 2021
Neumann-A
reviewed
Aug 9, 2021
Merged
57d4756 to
8e06356
Compare
JackBoosY
approved these changes
Aug 12, 2021
Contributor
|
This LGTM, thanks for the PR and sincerest apologies that it took so long to get merged! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Aug 20, 2021
[kf5windowsystem] fix cmake.in for static usage; extra fixes (microsoft#19440)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
No change.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.