[abseil] Upgrade to 20210324.2#19357
Merged
dan-shaw merged 18 commits intomicrosoft:masterfrom Aug 19, 2021
Merged
Conversation
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/abseil.json b/versions/a-/abseil.json
index 1048c20..3118536 100644
--- a/versions/a-/abseil.json
+++ b/versions/a-/abseil.json
@@ -2,7 +2,7 @@
"versions": [
{
"git-tree": "7afb928a59ae165fb87f21a8b3345fb93547a09c",
- "version-string": "2021-03-24",
+ "version-date": "2021-03-24",
"port-version": 2
},
{
JonLiu1993
added
the
category:port-update
JonLiu1993
suggested changes
Aug 4, 2021
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/abseil.json b/versions/a-/abseil.json
index 32b771e..3118536 100644
--- a/versions/a-/abseil.json
+++ b/versions/a-/abseil.json
@@ -2,7 +2,7 @@
"versions": [
{
"git-tree": "7afb928a59ae165fb87f21a8b3345fb93547a09c",
- "version-date": "2021-03-24.2",
+ "version-date": "2021-03-24",
"port-version": 2
},
{
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for abseil but no changes to version or port version.
-- Version: 2021-03-24
-- Old SHA: d58deb5198f8a1d72eafc3e1d6bdb36197fac470
-- New SHA: 06129ba692a74865ec8f0189cd61038fcbd8d629
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/abseil.json b/versions/a-/abseil.json
index 3118536..20e992d 100644
--- a/versions/a-/abseil.json
+++ b/versions/a-/abseil.json
@@ -1,10 +1,5 @@
{
"versions": [
- {
- "git-tree": "7afb928a59ae165fb87f21a8b3345fb93547a09c",
- "version-date": "2021-03-24",
- "port-version": 2
- },
{
"git-tree": "bae9c59114a4a2dc396452fb9e988a9da881b4f4",
"version-date": "2021-03-24",
diff --git a/versions/baseline.json b/versions/baseline.json
index c6cd9c6..5dd702d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -10,7 +10,7 @@
},
"abseil": {
"baseline": "2021-03-24",
- "port-version": 2
+ "port-version": 0
},
"absent": {
"baseline": "0.3.1",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/abseil/vcpkg.json b/ports/abseil/vcpkg.json
index 620deb5..f8b9059 100644
--- a/ports/abseil/vcpkg.json
+++ b/ports/abseil/vcpkg.json
@@ -1,7 +1,6 @@
{
"name": "abseil",
"version-date": "2021-03-24.2",
- "port-version": 0,
"description": [
"an open-source collection designed to augment the C++ standard library.",
"Abseil is an open-source collection of C++ library code designed to augment the C++ standard library. The Abseil library code is collected from Google's own C++ code base, has been extensively tested and used in production, and is the same code we depend on in our daily coding lives.",After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/abseil.json b/versions/a-/abseil.json
index 3286d61..125e46b 100644
--- a/versions/a-/abseil.json
+++ b/versions/a-/abseil.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "7afb928a59ae165fb87f21a8b3345fb93547a09c",
+ "git-tree": "628a8266bc65edd927ceea767b340361eae4ff96",
"version-date": "2021-03-24.2",
"port-version": 0
},
JonLiu1993
reviewed
Aug 4, 2021
Contributor
JonLiu1993
left a comment
JonLiu1993
left a comment
There was a problem hiding this comment.
Please run command "./vcpkg x-add-version abseil --overwrite-version" then commit the changes again
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/abseil/vcpkg.json b/ports/abseil/vcpkg.json
index 620deb5..f8b9059 100644
--- a/ports/abseil/vcpkg.json
+++ b/ports/abseil/vcpkg.json
@@ -1,7 +1,6 @@
{
"name": "abseil",
"version-date": "2021-03-24.2",
- "port-version": 0,
"description": [
"an open-source collection designed to augment the C++ standard library.",
"Abseil is an open-source collection of C++ library code designed to augment the C++ standard library. The Abseil library code is collected from Google's own C++ code base, has been extensively tested and used in production, and is the same code we depend on in our daily coding lives.",
Contributor
|
After completing the modification, please run the command "./vcpkg x-add-version abseil --overwrite-version" and submit the changes again |
JonLiu1993
suggested changes
Aug 4, 2021
ports/abseil/vcpkg.json
Outdated
| "name": "abseil", | ||
| "version-date": "2021-03-24", | ||
| "port-version": 1, | ||
| "version-date": "2021-03-24.2", |
Contributor
There was a problem hiding this comment.
Suggested change
| "version-date": "2021-03-24.2", | |
| "version-date": "2021-03-24", |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for abseil but no changes to version or port version.
-- Version: 2021-03-24
-- Old SHA: d58deb5198f8a1d72eafc3e1d6bdb36197fac470
-- New SHA: 06129ba692a74865ec8f0189cd61038fcbd8d629
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/abseil.json b/versions/a-/abseil.json
index 0ab6652..20e992d 100644
--- a/versions/a-/abseil.json
+++ b/versions/a-/abseil.json
@@ -1,10 +1,5 @@
{
"versions": [
- {
- "git-tree": "628a8266bc65edd927ceea767b340361eae4ff96",
- "version-date": "2021-03-24",
- "port-version": 0
- },
{
"git-tree": "bae9c59114a4a2dc396452fb9e988a9da881b4f4",
"version-date": "2021-03-24",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for abseil but no changes to version or port version.
-- Version: 2021-03-24
-- Old SHA: d58deb5198f8a1d72eafc3e1d6bdb36197fac470
-- New SHA: 06129ba692a74865ec8f0189cd61038fcbd8d629
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Contributor
|
@srgbtl ,Where is the versions/a-/abseil.json file? |
Contributor
Author
See: #19357 (review) Based on previous PR #16664 where a newer patch was applied, it should be done as in dcde413 |
JonLiu1993
suggested changes
Aug 5, 2021
JonLiu1993
suggested changes
Aug 6, 2021
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for abseil but no changes to version or port version.
-- Version: 2021-03-24
-- Old SHA: d58deb5198f8a1d72eafc3e1d6bdb36197fac470
-- New SHA: 06129ba692a74865ec8f0189cd61038fcbd8d629
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/abseil.json b/versions/a-/abseil.json
index 3118536..20e992d 100644
--- a/versions/a-/abseil.json
+++ b/versions/a-/abseil.json
@@ -1,10 +1,5 @@
{
"versions": [
- {
- "git-tree": "7afb928a59ae165fb87f21a8b3345fb93547a09c",
- "version-date": "2021-03-24",
- "port-version": 2
- },
{
"git-tree": "bae9c59114a4a2dc396452fb9e988a9da881b4f4",
"version-date": "2021-03-24",
diff --git a/versions/baseline.json b/versions/baseline.json
index 8d3554d..061c6e2 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -10,7 +10,7 @@
},
"abseil": {
"baseline": "2021-03-24",
- "port-version": 2
+ "port-version": 0
},
"absent": {
"baseline": "0.3.1",
Contributor
Author
|
@JonLiu1993 removed. What should be done next? How to deal with errors reported in checks? |
JonLiu1993
approved these changes
Aug 9, 2021
JonLiu1993
added
the
info:needs-maintainer-attention
PhoebeHui
reviewed
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.