Conversation
1598d2d to
99dcfb1
Compare
a9c2f29 to
4fcde48
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@JonLiu1993 ping..? I feel like there is some part of the process to get PRs merged here that I am missing. I'd like to know so I can be more effective next time. |
|
@BillyONeal, Could you please help merge this pr? |
It isn't your fault; we had some "in real life" problems getting through the volume of submitted PRs over the last couple weeks and some stuff got dropped on the floor, and completely new ports always require fairly careful review. |
ports/sbp/portfile.cmake
Outdated
There was a problem hiding this comment.
This is a bit strange, where did the import libs go?
There was a problem hiding this comment.
I think this was before dyn imports were disabled on Windows at the top of the portfile - # See https://github.com/swift-nav/libsbp/issues/1062
|
@jayvdb ,Coud you consider BillyONeal's reply? |
f2863ad to
40ba74d
Compare
Closes microsoft#19218
|
Thanks for the new port! |
|
🎉 |
Describe the pull request
What does your PR fix?
Fixes [New Port Request] sbp #19218
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/