Skip to content

[sbp] new port - #19335

Merged
Billy O'Neal (BillyONeal) merged 5 commits into
microsoft:masterfrom
jayvdb:add-sbp
Sep 14, 2021
Merged

[sbp] new port#19335
Billy O'Neal (BillyONeal) merged 5 commits into
microsoft:masterfrom
jayvdb:add-sbp

Conversation

@jayvdb

@jayvdb John Vandenberg (jayvdb) commented Aug 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes [New Port Request] sbp #19218

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost

Deleted user (ghost) commented Aug 3, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@jayvdb
John Vandenberg (jayvdb) force-pushed the add-sbp branch 11 times, most recently from 1598d2d to 99dcfb1 Compare August 3, 2021 14:01
@jayvdb
John Vandenberg (jayvdb) marked this pull request as ready for review August 3, 2021 14:06
mathisloge
Mathis Logemann (mathisloge) suggested changes Aug 3, 2021
View reviewed changes
Comment thread ports/sbp/vcpkg.json Outdated
@JonLiu1993 JonLiu1993 self-assigned this Aug 4, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 4, 2021
@jayvdb
John Vandenberg (jayvdb) force-pushed the add-sbp branch 2 times, most recently from a9c2f29 to 4fcde48 Compare August 4, 2021 05:53
JonLiu1993
JonLiu1993 suggested changes Aug 4, 2021
View reviewed changes
Comment thread ports/sbp/portfile.cmake Outdated
Comment thread ports/sbp/portfile.cmake Outdated
Comment thread ports/sbp/vcpkg.json Outdated
Comment thread ports/sbp/vcpkg.json Outdated
JonLiu1993
JonLiu1993 reviewed Aug 4, 2021
View reviewed changes
Comment thread ports/sbp/portfile.cmake Outdated
jayvdb
John Vandenberg (jayvdb) commented Aug 6, 2021
View reviewed changes
Comment thread ports/sbp/portfile.cmake Outdated
@JonLiu1993

JonLiu1993 commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 23, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jayvdb

John Vandenberg (jayvdb) commented Aug 30, 2021

Copy link
Copy Markdown
Contributor Author

JonLiu1993 ping..? I feel like there is some part of the process to get PRs merged here that I am missing. I'd like to know so I can be more effective next time.

@JonLiu1993

JonLiu1993 commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

Billy O'Neal (@BillyONeal), Could you please help merge this pr?

@BillyONeal

Billy O'Neal (BillyONeal) commented Sep 1, 2021

Copy link
Copy Markdown
Member

JonLiu1993 ping..? I feel like there is some part of the process to get PRs merged here that I am missing. I'd like to know so I can be more effective next time.

It isn't your fault; we had some "in real life" problems getting through the volume of submitted PRs over the last couple weeks and some stuff got dropped on the floor, and completely new ports always require fairly careful review.

BillyONeal
Billy O'Neal (BillyONeal) reviewed Sep 1, 2021
View reviewed changes
Comment thread ports/sbp/portfile.cmake Outdated

@BillyONeal Billy O'Neal (BillyONeal) Sep 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit strange, where did the import libs go?

@jayvdb John Vandenberg (jayvdb) Sep 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was before dyn imports were disabled on Windows at the top of the portfile - # See https://github.com/swift-nav/libsbp/issues/1062

BillyONeal
Billy O'Neal (BillyONeal) reviewed Sep 1, 2021
View reviewed changes
Comment thread ports/sbp/vcpkg.json Outdated
@JonLiu1993 JonLiu1993 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 2, 2021
@JonLiu1993

JonLiu1993 commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

John Vandenberg (@jayvdb) ,Coud you consider BillyONeal's reply？

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 13, 2021
@BillyONeal
Billy O'Neal (BillyONeal) merged commit cce4bf5 into microsoft:master Sep 14, 2021
@BillyONeal

Billy O'Neal (BillyONeal) commented Sep 14, 2021

Copy link
Copy Markdown
Member

Thanks for the new port!

@silverjam

Jason Mobarak (silverjam) commented Sep 14, 2021

Copy link
Copy Markdown

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal Billy O'Neal (BillyONeal) BillyONeal left review comments
@github-actions github-actions[bot] github-actions[bot] approved these changes
+2 more reviewers
@mathisloge Mathis Logemann (mathisloge) mathisloge requested changes
@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New Port Request] sbp

5 participants

@jayvdb @JonLiu1993 @BillyONeal @silverjam @mathisloge