Skip to content

[sbp] new port#19335

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
jayvdb:add-sbp
Sep 14, 2021
Merged

[sbp] new port#19335
BillyONeal merged 5 commits intomicrosoft:masterfrom
jayvdb:add-sbp

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Aug 3, 2021

Describe the pull request

  • What does your PR fix?

    Fixes [New Port Request] sbp #19218

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Aug 3, 2021

CLA assistant check
All CLA requirements met.

@jayvdb jayvdb force-pushed the add-sbp branch 11 times, most recently from 1598d2d to 99dcfb1 Compare August 3, 2021 14:01
@jayvdb jayvdb marked this pull request as ready for review August 3, 2021 14:06
@JonLiu1993 JonLiu1993 self-assigned this Aug 4, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 4, 2021
@jayvdb jayvdb force-pushed the add-sbp branch 2 times, most recently from a9c2f29 to 4fcde48 Compare August 4, 2021 05:53
@JonLiu1993
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jayvdb
Copy link
Contributor Author

jayvdb commented Aug 30, 2021

@JonLiu1993 ping..? I feel like there is some part of the process to get PRs merged here that I am missing. I'd like to know so I can be more effective next time.

@JonLiu1993
Copy link
Contributor

@BillyONeal, Could you please help merge this pr?

@BillyONeal
Copy link
Member

@JonLiu1993 ping..? I feel like there is some part of the process to get PRs merged here that I am missing. I'd like to know so I can be more effective next time.

It isn't your fault; we had some "in real life" problems getting through the volume of submitted PRs over the last couple weeks and some stuff got dropped on the floor, and completely new ports always require fairly careful review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit strange, where did the import libs go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was before dyn imports were disabled on Windows at the top of the portfile - # See https://github.com/swift-nav/libsbp/issues/1062

@JonLiu1993 JonLiu1993 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 2, 2021
@JonLiu1993
Copy link
Contributor

@jayvdb ,Coud you consider BillyONeal's reply?

@jayvdb jayvdb force-pushed the add-sbp branch 2 times, most recently from f2863ad to 40ba74d Compare September 11, 2021 05:06
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 13, 2021
@BillyONeal BillyONeal merged commit cce4bf5 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

@silverjam
Copy link

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Port Request] sbp

5 participants