Skip to content

[Azure-*] Remove version constraint#19299

Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/Azure
Aug 4, 2021
Merged

[Azure-*] Remove version constraint#19299
dan-shaw merged 5 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/Azure

Conversation

@PhoebeHui
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui commented Aug 2, 2021

Fixes #19267

This version constraint used in related ports cause the failures in manifest mode. See #18779 (comment)

Failures:

Error: no version entry for azure-storage-common-cpp at version 12.0.0.
We are currently using the version in the ports tree (12.0.1).
Error: no version entry for azure-core-cpp at version 1.0.0.
We are currently using the version in the ports tree (1.1.0).
Error: no version entry for azure-storage-blobs-cpp at version 12.0.0.
We are currently using the version in the ports tree (12.0.1).
Error: no version entry for azure-storage-common-cpp at version 12.0.0.
We are currently using the version in the ports tree (12.0.1).

cc @ahsonkhan cc @RickWinter, @vhvb1989

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 2, 2021
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 2, 2021
@MarkVabulas
Copy link
Copy Markdown

Thank you, this fixes the issues raised in #19267

@dan-shaw dan-shaw merged commit 8cca60b into microsoft:master Aug 4, 2021
@antkmsft
Copy link
Copy Markdown
Member

antkmsft commented Aug 6, 2021

@PhoebeHui, @ras0219-msft, what should be our approach with version constraints now?
These versions should have version entries, because we released them after the feature was public.
I can see an entry for the version 1.0.0, for example: https://github.com/microsoft/vcpkg/blob/master/versions/a-/azure-core-cpp.json#L8-L12
Is this a way the bug should have been fixed?

You asked us to remove the version constraint for the old version of libcurl, with explanation that old versions are not backfilled (https://github.com/microsoft/vcpkg/pull/18779/files/0863a7b31bccd855731024083a2505c2b41bdd66), but with azure-sdk releases it should not be the case?

We release azure-core version 1.2.0, and are release azure-identity version 1.1.0, which will only compile with azure-core 1.2.0, how should we manifest that? You removed "version>=", is there other way?
And if not, how do we get there to achieve what we want?

Out of curiosity, if we should not be using version>= in this case, what scenarios should version>= be used in?

And also, if this is something that should not be used, is it possible to enforce it via CI checks? Last time, CI did not catch using the version constraint with libcurl, here we are updating the manifests retroactively - I think, if CI was clearer about this, it would've been better for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure with vcpkg.json manifest file and azure-

5 participants