Skip to content

[kf5jobwidgets] new port#19200

Merged
dan-shaw merged 16 commits intomicrosoft:masterfrom
wrobelda:kf5jobwidgets
Aug 2, 2021
Merged

[kf5jobwidgets] new port#19200
dan-shaw merged 16 commits intomicrosoft:masterfrom
wrobelda:kf5jobwidgets

Conversation

@wrobelda
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Adds new port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All official.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@wrobelda wrobelda marked this pull request as ready for review July 28, 2021 19:51
@JonLiu1993 JonLiu1993 self-assigned this Jul 29, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 29, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5jobwidgets but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: eb3fb44b6ca3a89a891d38685962f7420da32b1d
-- New SHA: e5b53e0c0f55aa474dd103a23592636a0394d34e
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5jobwidgets but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: eb3fb44b6ca3a89a891d38685962f7420da32b1d
-- New SHA: 99169f5b8a9c3869d52fbff72aa93decc47a9a52
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5jobwidgets but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 3ec67298597c6ac5df5095ca23020ccb46b60bd7
-- New SHA: 2d067909dffdef68594d402b6cbdda81f2bdc8f3
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

wrobelda and others added 4 commits July 29, 2021 13:04
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5jobwidgets but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 2d067909dffdef68594d402b6cbdda81f2bdc8f3
-- New SHA: f27084e9b945a5b76199b9b51c620da3f78ad5fa
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

wrobelda added a commit to wrobelda/vcpkg that referenced this pull request Jul 29, 2021
Many projects will have more than a single license. Such projects typically have a LICENSES folder with SPDX copies of them. This explains how to copy them all instead just a single one.

Such projects with multiple licenses should be officially recognized, so that maintainers are aware of it. See e.g.: microsoft#19199 (review)
microsoft#19200 (comment)
@wrobelda
Copy link
Contributor Author

@JonLiu1993 all fixed now

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Aug 2, 2021
@dan-shaw dan-shaw merged commit e47b72b into microsoft:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants