Skip to content

[nghttp2] Update and fixes#19163

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
dg0yt:nghttp2
Jul 28, 2021
Merged

[nghttp2] Update and fixes#19163
vicroms merged 5 commits intomicrosoft:masterfrom
dg0yt:nghttp2

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 27, 2021

  • What does your PR fix?

    • Updates nghttp2 to v1.44.0
    • Modernizes the port
    • Fixes linkage configuration
    • Adds NGHTTP2_STATICLIB to the headers for static linkage on Windows, making a patch in port curl obsolete.
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@dg0yt dg0yt changed the title [mghttp2] Update and fixes [nghttp2] Update and fixes Jul 27, 2021
@dg0yt dg0yt mentioned this pull request Jul 27, 2021
8 tasks
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 7dbc05515b44bf54d2a42b4da9d1e1f910868b86 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/n-/nghttp2.json b/versions/n-/nghttp2.json
index 9eadf60..4cd034b 100644
--- a/versions/n-/nghttp2.json
+++ b/versions/n-/nghttp2.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "9afa42d07c41c9d2db4ee3f4e6636d347bd2c8dc",
+      "git-tree": "7d98b71b7948db8173a563483081700e706268b0",
       "version": "1.44.0",
       "port-version": 0
     },

@JonLiu1993 JonLiu1993 self-assigned this Jul 27, 2021
@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision labels Jul 27, 2021
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 28, 2021
@JonLiu1993
Copy link
Contributor

@dg0yt ,Thanks for your pr.

@vicroms vicroms merged commit 018c0fa into microsoft:master Jul 28, 2021
@dg0yt dg0yt deleted the nghttp2 branch July 28, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants