Skip to content

[libidn2] Fixes for mingw and minor issues#19002

Merged
vicroms merged 9 commits intomicrosoft:masterfrom
dg0yt:libidn2
Jul 26, 2021
Merged

[libidn2] Fixes for mingw and minor issues#19002
vicroms merged 9 commits intomicrosoft:masterfrom
dg0yt:libidn2

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 19, 2021

  • What does your PR fix?

    • Fixes building with mingw (needed for curl). For faster build, it uses the cmake build system which is also used for MSVC.
    • Installs the pc file also for cmake builds.
    • Modernizes the portfile
    • Use libunistring for non-windows
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes, but I am still working on this PR.

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 19, 2021
@dg0yt dg0yt mentioned this pull request Jul 20, 2021
8 tasks
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 22, 2021

I can pick up libunistring in another PR. But this one is needed for updating curl.

@dg0yt dg0yt marked this pull request as ready for review July 22, 2021 06:11
@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jul 26, 2021
@vicroms vicroms merged commit b57e29a into microsoft:master Jul 26, 2021
@dg0yt dg0yt deleted the libidn2 branch July 29, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants