Skip to content

[libffi] Update to v3.4.2#18995

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
longnguyen2004:libffi-v3.4.2
Jul 19, 2021
Merged

[libffi] Update to v3.4.2#18995
BillyONeal merged 4 commits intomicrosoft:masterfrom
longnguyen2004:libffi-v3.4.2

Conversation

@longnguyen2004
Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes libffi build failure #18076
    Update libffi to v3.4.2 and remove upstreamed patches

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, not needed

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@talregev
Copy link
Copy Markdown
Contributor

I am run it on the ci. I will let you know the result.

@talregev
Copy link
Copy Markdown
Contributor

I also check on my wsl:
I can confirm it working for:
--triplet=x64-mingw-static
it not working for:
--triplet=x86-mingw-static

Not sure if we need to support x86?

@talregev
Copy link
Copy Markdown
Contributor

For x86-mingw-static

CMake Error at CMakeLists.txt:19 (message):
  Unknown processor: i686

logs:
libffi.zip

@talregev
Copy link
Copy Markdown
Contributor

Now I can confirm it working on my wsl also with --triplet=x86-mingw-static

Thank you.

@JonLiu1993 JonLiu1993 self-assigned this Jul 19, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 19, 2021
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 19, 2021
@BillyONeal BillyONeal merged commit 3a28333 into microsoft:master Jul 19, 2021
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your contribution!

@talregev
Copy link
Copy Markdown
Contributor

Thank you!

@longnguyen2004 longnguyen2004 deleted the libffi-v3.4.2 branch July 20, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libffi build failure

4 participants