[embree2] Fix static linking#18985
Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom Jul 20, 2021
Merged
Conversation
Recently attempting to build embree2 is causing our osx workers to die. Example recent CIs: https://dev.azure.com/vcpkg/public/_build/results?buildId=56146 https://dev.azure.com/vcpkg/public/_build/results?buildId=55886 https://dev.azure.com/vcpkg/public/_build/results?buildId=55802 Notably, we don't see this problem in PRs because it is marked "fail" in ci.baseline.txt. Initially, I was going to change it to skip, but observed that the project uses an ordinary cmake build and all the failing triplets were static ones. If this PR passes, the hope is that CI with this change will pass too.
PhoebeHui
added
category:port-bug
…isn't prepared for it.
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
approved these changes
Jul 20, 2021
PhoebeHui
added
the
info:needs-maintainer-attention
Member
Author
|
Thanks for the review @PhoebeHui :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently attempting to build embree2 is causing our osx workers to die. Example recent CIs:
https://dev.azure.com/vcpkg/public/_build/results?buildId=56146
https://dev.azure.com/vcpkg/public/_build/results?buildId=55886
https://dev.azure.com/vcpkg/public/_build/results?buildId=55802
Notably, we don't see this problem in PRs because it is marked "fail" in ci.baseline.txt. Initially, I was going to change it to skip, but observed that the project uses an ordinary cmake build and all the failing triplets were static ones.
Unfortunately, PR testing replicated the broke MacOS and Linux behavior, so this PR adds "supports: windows". If someone wants embree2 on non-Windows we would love to see a contribution that makes it work.