Skip to content

[libsigcpp] Fix usage in static build#18944

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-libsigcpp-usage
Jul 26, 2021
Merged

[libsigcpp] Fix usage in static build#18944
vicroms merged 5 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-libsigcpp-usage

Conversation

@NancyLi1013
Copy link
Contributor

Describe the pull request

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 14, 2021
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This LGTM once my suggestion is applied.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 16, 2021
@NancyLi1013
Copy link
Contributor Author

The failures caused by libgo on x64-windows-static:

CMake Error at CMakeLists.txt:47 (configure_file):
  No such file or directory

Will be fixed via PR #19037

The failures caused by rxspencer on x86-windows:

D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(127): error C2059: syntax error: '>'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(127): error C2059: syntax error: ')'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(129): error C2059: syntax error: 'if'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2059: syntax error: 'string'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2143: syntax error: missing ')' before '->'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2143: syntax error: missing '{' before '->'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2059: syntax error: '->'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2059: syntax error: ')'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(133): error C2059: syntax error: 'return'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(134): error C2059: syntax error: '}'

May be fixed via PR #19039

The failures caused by pistache on x64-linux:

CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:95 (message):
  '/mnt/vcpkg-ci/packages/pistache_x64-linux/debug/lib/cmake/RapidJSON' does
  not exist.
Call Stack (most recent call first):
  ports/pistache/portfile.cmake:22 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:140 (include)

Seems to be fixed via PR #18994

@PhoebeHui PhoebeHui removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 21, 2021
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 22, 2021
@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jul 23, 2021
@vicroms vicroms merged commit be01bbc into microsoft:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[libsigcpp-3] build failure

6 participants