Fix nativefiledialog port using build time include dir#18923
Merged
vicroms merged 7 commits intomicrosoft:masterfrom Jul 16, 2021
Merged
Fix nativefiledialog port using build time include dir#18923vicroms merged 7 commits intomicrosoft:masterfrom
vicroms merged 7 commits intomicrosoft:masterfrom
Conversation
45a1f5f to
4394d9b
Compare
4394d9b to
29f9654
Compare
JackBoosY
suggested changes
Jul 13, 2021
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
JackBoosY
suggested changes
Jul 14, 2021
JackBoosY
approved these changes
Jul 14, 2021
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes installed lib include path pointing to build-time location. Problem is in this bit:
For install target, BUILD_INTERFACE evaluates to empty string, which is expanded to current build folder and so
unofficial-nativefiledialog-config.cmakehas lines like these that include absolute build folder path:Separating into two different target_include_directories fixes it.
Which triplets are supported/not supported? Have you updated the CI baseline?
All (except UWP), No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes