[vcpkg] Add vcpkg installed libraries to msvc external include path#18820
[vcpkg] Add vcpkg installed libraries to msvc external include path#18820ras0219-msft merged 1 commit intomicrosoft:masterfrom RT2Code:external-include-path
Conversation
|
It will unavaiable on the older Visual Studio version. |
JackBoosY
added
category:vcpkg-feature
|
True, but this is expected. Previous Visual Studio versions will just ignore this property and keep going without any problem. |
RT2Code
changed the title
PhoebeHui
removed
the
requires:vcpkg-team-review
|
Ready for review now? |
|
Sorry, I misunderstood the purpose of draft PRs, it is ready for review. |
JackBoosY
added
the
requires:vcpkg-team-review
|
I need my colleague to confirm this. |
|
Ping @ras0219-msft @BillyONeal @vicroms for review this PR. |
|
This looks like a straightforward improvement to me -- thanks for the PR! |
|
I'm trying to get all my external code marked as external, so I can disable warnings on it. This includes vcpkg installed headers. I stumbled upon this addition and see that it was merged, but it doesn't work for me. The vcpkg include dir is passed to cl.exe with the normal Do I need to change any settings? |
5 participants
Now that we have a way to specify external headers in Visual Studio, I thought it would be convenient to add the vcpkg include directory to it with the integrate install command.
I made a draft pull request because, even if this is a very small change, my knowledge of the vcpkg internals is superficial and I'm not entirely sure the way I did it is clean or complete.