Skip to content

[scripts-audit] windows scripts#18786

Closed
strega-nil wants to merge 2 commits intomicrosoft:masterfrom
strega-nil:windows-scripts
Closed

[scripts-audit] windows scripts#18786
strega-nil wants to merge 2 commits intomicrosoft:masterfrom
strega-nil:windows-scripts

Conversation

@strega-nil
Copy link
Contributor

See issue #17691

if(ENV{VAR}) doesn't expand "$ENV{VAR}", much to my chagrin
@strega-nil strega-nil marked this pull request as ready for review July 13, 2021 16:37
@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

I still think these should not exist.

@strega-nil-ms
Copy link
Contributor

/azp run

@microsoft microsoft deleted a comment from azure-pipelines bot Jul 16, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from strega-nil Jul 16, 2021
@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Jul 16, 2021

@BillyONeal unfortunately these are already stabilized... we can deprecate but that's about it.

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Jul 19, 2021
@strega-nil-ms
Copy link
Contributor

Closed as part of rollup PR #19001

strega-nil-ms added a commit that referenced this pull request Jul 20, 2021
* [rollup:2021-07-16 1/7] PR #18201 (@JackBoosY)

[vcpkg-cmake] Add check for unused cmake variables

* [rollup:2021-07-16 2/7] PR #18397 (@strega-nil)

[vcpkg_list] add new function

* [rollup:2021-07-16 3/7] PR #18782 (@strega-nil)

[scripts-audit] vcpkg_build_ninja

* [rollup:2021-07-16 4/7] PR #18784 (@strega-nil)

[scripts-audit] vcpkg_minimum_required

* [rollup:2021-07-16 5/7] PR #18785 (@strega-nil)

[scripts-audit] vcpkg_replace_string

* [rollup:2021-07-16 6/7] PR #18786 (@strega-nil)

[scripts-audit] windows scripts

* [rollup:2021-07-16 7/7] PR #18945 (@strega-nil)

[many ports] remove deprecated vcpkg_check_features call [1/5]

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: PhoebeHui <20694052+PhoebeHui@users.noreply.github.com>
@strega-nil strega-nil deleted the windows-scripts branch March 31, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants