[fontconfig] Fix x86-osx -> arm64-osx cross-compilation#18625
Conversation
|
could you add: before This also fixes the broken symlinks in fontconfig |
ports/fontconfig/build2.patch
Outdated
There was a problem hiding this comment.
Where does CFLAGS_FOR_BUILD come from, before #15605?
There was a problem hiding this comment.
@Lucius-Q-User, I didn't find the CFLAGS_FOR_BUILD in fontconfig, so why do you change it?
There was a problem hiding this comment.
CFLAGS refers to target system cflags, which can break the build, (e.g -arch flag for clang, or -march/-mcpu flags)
There was a problem hiding this comment.
CFLAGS_FOR_BUILD might be set for cross builds after #15605, but for now you miss CFLAGS for native builds.
In addition, $(LIBINTL) can go wrong as well for cross builds.
There was a problem hiding this comment.
Alternatively, we can update the version of fontconfig that is currently in the tree. Newer versions made fc-case, which is the source of cross-compile problems into a python script.
There was a problem hiding this comment.
would it be ok to conditionally include cflags depending on whether we are cross-compiling or not?
That breaks the build, macos version of ln does not support -r |
|
Looks like simage was broken even before the patch. |
|
simage failures would be fixed by PR #18645 |
|
@Lucius-Q-User, the dependency PR has been closed, does this PR still be valid? can I close it? |
|
The dependency PR was closed because fontconfig was updated via a different PR. Since fontconfig was updated, it now uses a completely different build system (meson instead of automake) and this PR no longer applies. |
Pass host system cflags instead of target system cflags to tools that are supposed to run on host system.
Run host system version of fc-cache instead of target system.
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
x86-osx, arm64-osx No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/