[icu] Fix x86-osx -> arm64-osx cross-compilation#18608
Merged
Conversation
Contributor
|
JackBoosY
added
the
category:community-triplet
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
JackBoosY
reviewed
Jul 22, 2021
Contributor
|
@Lucius-Q-User Can you manually test your changes in arm64-osx? Our pipeline won't test this triplet. |
Author
|
Tested builds for native arm64, arm64->x64 and x64->arm64. All of them build. |
JackBoosY
approved these changes
Jul 23, 2021
JackBoosY
added
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcpkg_configure_make only passes the --host flags if the configure script is marked as autoconf-generated. This commit marks that script as autoconf-generated
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
x86-osx, arm64-osx No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/