[wxwidgets] Fix wx-config --libs output by JackBoosY · Pull Request #18580 · microsoft/vcpkg

JackBoosY · 2021-06-22T06:40:17Z

Fix command ./wx-config --libs output, add -l to the system library.
From:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so -lwx_gtk3u_core-3.1 gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so libjpeg.a libpng.a> libpng16d.a> libz.a m libtiff.a> libtiffd.a> liblzma.a> liblzmad.a> libjpeg.a libz.a m gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so -lwx_baseu-3.1 libexpat.a> libexpat.a> gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so libz.a -lwxregexu-3.1 secret-1 gio-2.0 gobject-2.0 glib-2.0 libc.so -pthread dl

to:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a -lwx_gtk3u_core-3.1 -llibpng.a> -llibpng16d.a> -llibtiff.a> -llibtiffd.a> -lliblzma.a> -lliblzmad.a> -llibjpeg.a -lm -lwx_baseu-3.1 -llibexpat.a> -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -llibSM.so -llibICE.so -llibX11.so -llibXext.so -llibXtst.so -llibz.a -lwxregexu-3.1 -lsecret-1 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -llibc.so -l-pthread -ldl-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a -lwx_gtk3u_core-3.1 -llibpng.a> -llibpng16d.a> -llibtiff.a> -llibtiffd.a> -lliblzma.a> -lliblzmad.a> -llibjpeg.a -lm -lwx_baseu-3.1 -llibexpat.a> -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -llibSM.so -llibICE.so -llibX11.so -llibXext.so -llibXtst.so -llibz.a -lwxregexu-3.1 -lsecret-1 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -llibc.so -pthread -ldl

Fixes #18298.

Depends on #17111.

Waiting for the upstream approval in wxWidgets/wxWidgets#2402.

talregev · 2021-06-22T07:47:06Z

@JackBoosY There is improvement!!!
also we need to ignore all .so file.
For .a file, we should remove the lib prefix and .a suffix and add -l flags

Also how wxwidgets do it without your fix? How their wx-config work when compile from source?
I think vcpkg add a system lib for this variable that it shouldn't

/usr/bin/ld: cannot find -llibpng.a
/usr/bin/ld: cannot find -llibexpat.a
/usr/bin/ld: cannot find -llibSM.so
/usr/bin/ld: cannot find -llibICE.so
/usr/bin/ld: cannot find -llibX11.so
/usr/bin/ld: cannot find -llibXext.so
/usr/bin/ld: cannot find -llibXtst.so
/usr/bin/ld: cannot find -llibz.a
/usr/bin/ld: cannot find -llibc.so

JackBoosY · 2021-06-22T08:28:08Z

@talregev Please check again:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a -lwx_gtk3u_core-3.1 -llibpng.a> -llibpng16d.a> -llibtiff.a> -llibtiffd.a> -lliblzma.a> -lliblzmad.a> -llibjpeg.a -lm -lwx_baseu-3.1 -llibexpat.a> -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -llibSM.so -llibICE.so -llibX11.so -llibXext.so -llibXtst.so -llibz.a -lwxregexu-3.1 -lsecret-1 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -llibc.so -pthread -ldl

talregev · 2021-06-22T08:36:10Z

@talregev Please check again:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a -lwx_gtk3u_core-3.1 -llibpng.a> -llibpng16d.a> -llibtiff.a> -llibtiffd.a> -lliblzma.a> -lliblzmad.a> -llibjpeg.a -lm -lwx_baseu-3.1 -llibexpat.a> -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -llibSM.so -llibICE.so -llibX11.so -llibXext.so -llibXtst.so -llibz.a -lwxregexu-3.1 -lsecret-1 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -llibc.so -pthread -ldl

@JackBoosY
This is the new output? If yes there is still same errors.

ports/wxwidgets/fix-wxconfig-libs-output.patch

talregev · 2021-06-22T08:57:37Z

You can learn how the flags should be as how we compile wxwidgets
I am upload the logs here too:
wxwidgets.zip

Also past here how we use ld flags when compile wxwidgets.
[794/795] : && /usr/bin/c++ -fPIC -g -rdynamic -pthread utils/CMakeFiles/wxrc.dir/__/__/__/utils/wxrc/wxrc.cpp.o -o lib/wxrc lib/libwx_baseu_xml-3.1.a lib/libwx_baseu-3.1.a /home/tal/boinc/3rdParty/linux/vcpkg/installed/x64-linux/debug/lib/libz.a lib/libwxregexu-3.1.a -lc -pthread -ldl -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 /usr/lib/x86_64-linux-gnu/libSM.so /usr/lib/x86_64-linux-gnu/libICE.so /usr/lib/x86_64-linux-gnu/libX11.so /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXtst.so /home/tal/boinc/3rdParty/linux/vcpkg/installed/x64-linux/debug/lib/libexpat.a && :

talregev · 2021-06-22T09:25:41Z

@JackBoosY Same errors after your change

/usr/bin/ld: cannot find -llibpng.a
/usr/bin/ld: cannot find -llibexpat.a
/usr/bin/ld: cannot find -llibSM.so
/usr/bin/ld: cannot find -llibICE.so
/usr/bin/ld: cannot find -llibX11.so
/usr/bin/ld: cannot find -llibXext.so
/usr/bin/ld: cannot find -llibXtst.so
/usr/bin/ld: cannot find -llibz.a
/usr/bin/ld: cannot find -llibc.so

dg0yt · 2021-06-22T10:19:14Z

ports/wxwidgets/fix-wxconfig-libs-output.patch

+                    # Do nothing
+                else()
+                    string(REGEX MATCH "^lib(.*).a$" CURR_STATIC_NAME ${dep_name})
+                    string(REGEX MATCH "^lib(.*).so$" CURR_DYNAMIC_NAME ${dep_name})


This stores the whole match (i.e. libz.a) in CURR_<...>_NAME. You will need to use CMAKE_MATCH_1 to get the "namespec" (i.e. z).

This seems to ignore osx (.dylib).

ports/wxwidgets/fix-wxconfig-libs-output.patch

talregev · 2021-06-23T04:11:39Z

@JackBoosY
Can you fix command ./wx-config --libs
From:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so -lwx_gtk3u_core-3.1 gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so libjpeg.a libpng.a> libpng16d.a> libz.a m libtiff.a> libtiffd.a> liblzma.a> liblzmad.a> libjpeg.a libz.a m gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so -lwx_baseu-3.1 libexpat.a> libexpat.a> gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so libz.a -lwxregexu-3.1 secret-1 gio-2.0 gobject-2.0 glib-2.0 libc.so -pthread dl

to:

-L/home/usr/work/17111/vcpkg/installed/x64-linux/lib/ -L/usr/lib/x86_64-linux-gnu/ -pthread 
libwx_gtk3u_xrc-3.1.a libwx_gtk3u_qa-3.1.a libwx_baseu_net-3.1.a libwx_gtk3u_html-3.1.a libwx_gtk3u_core-3.1.a libwx_baseu_xml-3.1.a libwx_baseu-3.1.a gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so -lwx_gtk3u_core-3.1 gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so libjpeg.a libpng.a> libpng16d.a> libz.a m libtiff.a> libtiffd.a> liblzma.a> liblzmad.a> libjpeg.a libz.a m gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so -lwx_baseu-3.1 libexpat.a> libexpat.a> gtk-3 gdk-3 pangocairo-1.0 pango-1.0 atk-1.0 cairo-gobject cairo gdk_pixbuf-2.0 gio-2.0 gobject-2.0 glib-2.0 libSM.so libICE.so libX11.so libXext.so libXtst.so libz.a -lwxregexu-3.1 secret-1 gio-2.0 gobject-2.0 glib-2.0 libc.so -pthread dl

talregev · 2021-06-23T04:13:50Z

@JackBoosY
Why you need to change and approve upstream?
Can you make a patch without involving them?
Can we talk on discord?
I am at vcpkg channel

dg0yt · 2021-06-23T05:31:00Z

I cannot deal with this today, but might come back to this soon.

I have a patch to resolve my Linux build issue.
wx-config --libs still has multiple issues:
- absolute paths pointing to packages
- trailing > such as -llibwebp.a>
- incorrect namespecs such as -llibc.so
There needs to be another wc-config in tools/wxwidgets/debug/bin

JackBoosY · 2021-06-23T05:40:51Z

@JackBoosY
Why you need to change and approve upstream?
Can you make a patch without involving them?
Can we talk on discord?
I am at vcpkg channel

Since it's a upstream bug, so we should wait for the upstream approval the changes.
Can you go to the vcpkg channel on slack?

talregev · 2021-06-23T05:57:03Z

Can you go to the vcpkg channel on slack?

Can you send me the link?

JackBoosY · 2021-06-23T06:05:14Z

Can you go to the vcpkg channel on slack?

Can you send me the link?

See #9184

JackBoosY · 2021-06-23T07:14:11Z

Current output:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib -pthread /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a /home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a /usr/lib/x86_64-linux-gnu/libSM.so /usr/lib/x86_64-linux-gnu/libICE.so /usr/lib/x86_64-linux-gnu/libX11.so /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXtst.so -lwx_gtk3u_core-3.1 /usr/lib/x86_64-linux-gnu/libSM.so /usr/lib/x86_64-linux-gnu/libICE.so /usr/lib/x86_64-linux-gnu/libX11.so /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXtst.so /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libjpeg.a /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libpng.a /home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libpng16d.a /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libtiff.a /home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libtiffd.a /home/usr/work/17111/vcpkg/installed/x64-linux/lib/liblzma.a /home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/liblzmad.a /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libjpeg.a /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a -lm /usr/lib/x86_64-linux-gnu/libSM.so /usr/lib/x86_64-linux-gnu/libICE.so /usr/lib/x86_64-linux-gnu/libX11.so /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXtst.so -lwx_baseu-3.1 /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libexpat.a /home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libexpat.a -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 /usr/lib/x86_64-linux-gnu/libSM.so /usr/lib/x86_64-linux-gnu/libICE.so /usr/lib/x86_64-linux-gnu/libX11.so /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXtst.so /home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a -lwxregexu-3.1 -lsecret-1 -lgio-2.0 -lgobject-2.0 -lglib-2.0 /usr/lib/x86_64-linux-gnu/libc.so -pthread -ldl

The abs path should be handled by portfile.cmake.

JackBoosY · 2021-06-23T08:23:30Z

Okay, I already create an upstream PR wxWidgets/wxWidgets#2402, let's wait for the official response.

talregev · 2021-06-23T08:30:13Z

@JackBoosY
I check in the test branch and it give me this error:

stdwx.h:49:10: fatal error: wx/wx.h: No such file or directory
   49 | #include <wx/wx.h>
      |          ^~~~~~~~~

I think it connect to this PR #17111

talregev · 2021-06-23T12:47:04Z

I check only this PR. There was a progress!
My ci give me new error:
/usr/bin/ld: /home/runner/work/boinc/boinc/3rdParty/linux/vcpkg/packages/wxwidgets_x64-linux/lib/libwx_gtk3u_core-3.1.a(utilsx11.cpp.o): undefined reference to symbol 'XGetWindowAttributes'

Stackoverflow solution:
https://stackoverflow.com/questions/44634459/fglut-libfglut-afreeglut-state-o-undefined-reference-to-symbol-xgetwindowatt

I think we should focus on this PR only, then this PR #17111, then the combination of both.

talregev · 2021-06-23T12:58:36Z

@JackBoosY I re-arrange your current output with multi line for the flags to spot the problem:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib 
-pthread 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so 
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
-lwx_gtk3u_core-3.1 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so 
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libjpeg.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libpng.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libpng16d.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libtiff.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libtiffd.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/liblzma.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/liblzmad.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libjpeg.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a 
-lm 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
-lwx_baseu-3.1 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libexpat.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libexpat.a 
-lgtk-3 
-lgdk-3 
-lpangocairo-1.0 
-lpango-1.0 
-latk-1.0 
-lcairo-gobject 
-lcairo 
-lgdk_pixbuf-2.0 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so 
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a 
-lwxregexu-3.1 
-lsecret-1 
-lgio-2.0 
-lgobject-2.0 
-lglib-2.0 
/usr/lib/x86_64-linux-gnu/libc.so 
-pthread 
-ldl

I think it missing the -lX11 after libwx_gtk3u_core-3.1.a
Also because it a release tool, we shouldn't allow debug lib in the flags.

for example:

/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libpng16d.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libtiffd.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libexpat.a

JackBoosY · 2021-06-24T08:15:47Z

@JackBoosY I re-arrange your current output with multi line for the flags to spot the problem:

-L/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib 
-pthread 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_xrc-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_qa-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_net-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_html-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_gtk3u_core-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu_xml-3.1.a 
/home/usr/work/17111/vcpkg/packages/wxwidgets_x64-linux/lib/wx/config/../../../lib/libwx_baseu-3.1.a 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so 
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
-lwx_gtk3u_core-3.1 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so 
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libjpeg.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libpng.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libpng16d.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libtiff.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libtiffd.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/liblzma.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/liblzmad.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libjpeg.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a 
-lm 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
-lwx_baseu-3.1 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libexpat.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libexpat.a 
-lgtk-3 
-lgdk-3 
-lpangocairo-1.0 
-lpango-1.0 
-latk-1.0 
-lcairo-gobject 
-lcairo 
-lgdk_pixbuf-2.0 
/usr/lib/x86_64-linux-gnu/libSM.so 
/usr/lib/x86_64-linux-gnu/libICE.so 
/usr/lib/x86_64-linux-gnu/libX11.so 
/usr/lib/x86_64-linux-gnu/libXext.so 
/usr/lib/x86_64-linux-gnu/libXtst.so 
/home/usr/work/17111/vcpkg/installed/x64-linux/lib/libz.a 
-lwxregexu-3.1 
-lsecret-1 
-lgio-2.0 
-lgobject-2.0 
-lglib-2.0 
/usr/lib/x86_64-linux-gnu/libc.so 
-pthread 
-ldl

I think it missing the -lX11 after libwx_gtk3u_core-3.1.a
Also because it a release tool, we shouldn't allow debug lib in the flags.

for example:

/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libpng16d.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libtiffd.a 
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libexpat.a

This part is fixing in #17111.

JackBoosY · 2021-06-24T09:22:24Z

for example:
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libpng16d.a
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libtiffd.a
/home/usr/work/17111/vcpkg/installed/x64-linux/debug/lib/libexpat.a

This part is a bug of string(REGEX), will be fixed in this PR.

talregev · 2021-06-25T11:58:28Z

You still didn't solve the libx bug:
combine both PRs #17111 #18580
Error in my ci:

/usr/bin/ld: /home/runner/work/boinc/boinc/3rdParty/linux/vcpkg/installed/x64-linux/tools/wxwidgets/../../lib/libwx_gtk3u_core-3.1.a(utilsx11.cpp.o): undefined reference to symbol 'XGetWindowAttributes'
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libX11.so: error adding symbols: DSO missing from command line

dg0yt · 2021-06-26T12:32:11Z

I have a patch to resolve my Linux build issue.

Actually I just disable this Cotire/PCH thing now by adding -DwxBUILD_PRECOMP=OFF to OPTIONS.
(It looks like it was only activated after some test. This might explain why it doesn't happen on all linux machines.)

talregev · 2021-06-26T12:33:49Z

@dg0yt Do you want to add this patch to this PR?
What problem that it solve?

playgithub · 2021-06-30T16:15:54Z

For Multiple Configuration Generators, e.g. Visual Studio / xcode, CMAKE_BUILD_TYPE is ignored.
In book "Professional Cmake" by Crage Scott (chapter 13):

Rather than referring to CMAKE_BUILD_TYPE in the CMakeLists.txt file, projects should instead use other more robust alternative techniques, such as generator expressions based on $<CONFIG:…>.

BTW, this is for modern cmake, i.e. a higher version of cmake.
For wxWidgets, cmake_minimum_required(VERSION 2.8.12), the guide might be not true.

dg0yt · 2021-07-01T06:41:14Z

@playgithub The patching is for building in vcpkg. AFAIK vcpkg doesn't use Multiple Configuration Generators at the moment.
Note that the output variables here are just substituted at configuration time, not consumed in a way which already evaluates generator expressions. Upstream's original treatment is broken, resulting in libtiff.a> libtiffd.a> output from wx-config when either -ltiff or -tiffd is needed. Maybe it could be patched in a different way, using file(GENERATE ...). Still it would need some treatment in the configuration step (such as transforming libtiffd.a to -ltiffd inside a generator expression) while the the final output would be created only at the generation step.

playgithub · 2021-07-05T11:30:54Z

Why not patch it in vcpkg first instead of waiting for the official fix?

JackBoosY · 2021-07-06T02:09:53Z

@playgithub That's becuase we need to wait for the upstream approval.

talregev · 2021-07-06T06:48:47Z

@JackBoosY People don't understand what is upstream.
And also don't understand why you wait for upstream approval.

Upstream mean wxwidgets in our case.
and @JackBoosY will explain why we wait for them.

dg0yt · 2021-07-06T07:42:50Z

In general packaging, it is fairly clear what upstream is. It is not only used in vcpkg.
Talking to upstream helps to avoid issues with unexpeced side effects, apart from facilitating an upstream solution which eventually replaces the patch.

JackBoosY · 2021-07-16T02:05:49Z

Since the upstream approval my changes, I can combine this PR to #17111.

Be-ing · 2021-07-16T02:20:20Z

Are you going to put this patch in vcpkg or just use the commit where your change was merged upstream as the source for the port?

JackBoosY · 2021-07-16T02:32:09Z

@Be-ing I will merge this changes to #17111, and waiting for update to the next version then remove this patch.

talregev · 2021-07-16T05:02:42Z

@JackBoosY Thanks!

talregev · 2021-07-25T09:41:40Z

@JackBoosY Any news? Can you merge this PR to the master?
This PR already approve by the upstream (wxwidgets). And it standalone with it own changes.
And you don't have time to finish #17111 as you already stated.
So these good changes should go to the master.

[wxwidgets] Fix wx-config --libs output

ef41783

JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal depends:upstream-changes Waiting on a change to the upstream project labels Jun 22, 2021

JackBoosY assigned NancyLi1013 Jun 22, 2021

JackBoosY marked this pull request as draft June 22, 2021 06:41

Re-fix output

1ba31de

JackBoosY mentioned this pull request Jun 22, 2021

[wxwidgets] Fix usage, add cmake options #17111

Closed

JackBoosY marked this pull request as ready for review June 22, 2021 07:03

talregev mentioned this pull request Jun 22, 2021

[Linux][Manager][Scripts] Compile linux manager with vcpkg BOINC/boinc#4385

Merged

3 tasks

Re-fix output

5ba7442

JackBoosY commented Jun 22, 2021

View reviewed changes

ports/wxwidgets/fix-wxconfig-libs-output.patch Outdated Show resolved Hide resolved

dg0yt reviewed Jun 22, 2021

View reviewed changes

JackBoosY closed this Jun 23, 2021

JackBoosY reopened this Jun 23, 2021

Re-fix

700b6eb

JackBoosY mentioned this pull request Jun 23, 2021

Fix option --libs output library path wxWidgets/wxWidgets#2402

Closed

JackBoosY mentioned this pull request Jun 24, 2021

[wxwidgets] With VS2019 solution generated by cmake in debug mode, release version of wx is used #18066

Closed

Determine the BUILD_TYPE

552d0fa

Be-ing mentioned this pull request Jul 14, 2021

Add CMake modules and build without vendored dependencies using vcpkg tenacityteam/tenacity-legacy#228

Merged

5 tasks

JackBoosY pushed a commit to JackBoosY/vcpkg that referenced this pull request Jul 27, 2021

Merge microsoft#18580 to this branch

9f9b55a

JackBoosY closed this Jul 27, 2021

JackBoosY deleted the dev/jack/fix-wxconfig-libs branch July 27, 2021 07:54

Conversation

JackBoosY commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Jun 22, 2021

Uh oh!

talregev commented Jun 22, 2021

Uh oh!

Uh oh!

talregev commented Jun 22, 2021

Uh oh!

talregev commented Jun 22, 2021

Uh oh!

dg0yt Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

talregev commented Jun 23, 2021

Uh oh!

talregev commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Jun 23, 2021

Uh oh!

JackBoosY commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented Jun 23, 2021

Uh oh!

JackBoosY commented Jun 23, 2021

Uh oh!

JackBoosY commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Jun 24, 2021

Uh oh!

JackBoosY commented Jun 24, 2021

Uh oh!

talregev commented Jun 25, 2021

Uh oh!

dg0yt commented Jun 26, 2021

Uh oh!

talregev commented Jun 26, 2021

Uh oh!

playgithub commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Jul 1, 2021

Uh oh!

playgithub commented Jul 5, 2021

Uh oh!

JackBoosY commented Jul 6, 2021

Uh oh!

talregev commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Jul 6, 2021

Uh oh!

JackBoosY commented Jul 16, 2021

Uh oh!

Be-ing commented Jul 16, 2021

Uh oh!

JackBoosY commented Jul 16, 2021

Uh oh!

talregev commented Jul 16, 2021

JackBoosY commented Jun 22, 2021 •

edited

Loading

talregev commented Jun 22, 2021 •

edited

Loading

talregev commented Jun 23, 2021 •

edited

Loading

JackBoosY commented Jun 23, 2021 •

edited

Loading

JackBoosY commented Jun 23, 2021 •

edited

Loading

JackBoosY commented Jun 23, 2021 •

edited

Loading

talregev commented Jun 23, 2021 •

edited

Loading

talregev commented Jun 23, 2021 •

edited

Loading

talregev commented Jun 23, 2021 •

edited

Loading

playgithub commented Jun 30, 2021 •

edited

Loading

talregev commented Jul 6, 2021 •

edited

Loading

talregev commented Jul 25, 2021 •

edited

Loading