[libzip] Update to version 1.8.0

[ctabin]

No description provided.

[JonLiu1993]

@ctabin ,Please add 'FEATURES' in the function"vcpkg_check_features" like:

vcpkg_check_features(
OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
    bzip2 ENABLE_BZIP2   
    liblzma ENABLE_LZMA    
    openssl ENABLE_OPENSSL   
    wincrypto ENABLE_WINDOWS_CRYPTO    
    commoncrypto ENABLE_COMMONCRYPTO   
    mbedtls ENABLE_MBEDTLS)

[JonLiu1993]

@ctabin ,Have you test all features locally in the following triplet:

• x64-windows
• x64-windows-static
• x64-linux

[JonLiu1993]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[PhoebeHui]

@ctabin, can you address the review suggestions and the CI test failures?

[ctabin]

@PhoebeHui Sorry for the late reply. I'll make the changes asap !

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 7dbc05515b44bf54d2a42b4da9d1e1f910868b86 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libzip.json b/versions/l-/libzip.json
index dea575d..ab7326c 100644
--- a/versions/l-/libzip.json
+++ b/versions/l-/libzip.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "26ba5523db09213f532821875542dba7afa04b65",
+      "git-tree": "a3adaf767853bfd7f7f2d511f4e3ec9eb9fa0b46",
       "version-semver": "1.8.0",
       "port-version": 0
     },

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 7dbc05515b44bf54d2a42b4da9d1e1f910868b86 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libzip.json b/versions/l-/libzip.json
index dea575d..ab7326c 100644
--- a/versions/l-/libzip.json
+++ b/versions/l-/libzip.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "26ba5523db09213f532821875542dba7afa04b65",
+      "git-tree": "a3adaf767853bfd7f7f2d511f4e3ec9eb9fa0b46",
       "version-semver": "1.8.0",
       "port-version": 0
     },

[JonLiu1993]

@ctabin ,Yesterday CI reported an error that the patch could not be applied. I re-made the patch and submitted it, but today it shows that there is still an error under Linux. Could you please take a look?

[ctabin]

Hi @JonLiu1993,
Thanks for help on this. Unfortunately, since I'm not the maintainer/developer of libzip, it is quite hard for me to know exactly what's going on.
So far, in the CI logs, I see:

2021-07-28T13:34:07.4376012Z Error: Building package ignition-fuel-tools4:x64-linux failed with: BUILD_FAILED
2021-07-28T13:34:07.4376816Z Elapsed time for package ignition-fuel-tools4:x64-linux: 2.381 s
2021-07-28T13:34:07.4377495Z Starting package 152/152: libzippp:x64-linux
2021-07-28T13:34:07.4378143Z Building package libzippp[core]:x64-linux...
2021-07-28T13:34:10.0290862Z -- Downloading https://github.com/ctabin/libzippp/archive/8299422194ce3c5be0677550ce3d6d4e15d40dd8.tar.gz -> ctabin-libzippp-8299422194ce3c5be0677550ce3d6d4e15d40dd8.tar.gz...
2021-07-28T13:34:10.0292386Z -- Extracting source /mnt/vcpkg-ci/downloads/ctabin-libzippp-8299422194ce3c5be0677550ce3d6d4e15d40dd8.tar.gz
2021-07-28T13:34:10.0293151Z -- Applying patch fix-find-lzma.patch
2021-07-28T13:34:10.0293894Z -- Using source at /mnt/vcpkg-ci/buildtrees/libzippp/src/4e15d40dd8-75ef2fee11.clean
2021-07-28T13:34:10.0294532Z -- Configuring x64-linux-dbg
2021-07-28T13:34:10.0295095Z -- Configuring x64-linux-rel
2021-07-28T13:34:10.0295860Z -- Building x64-linux-dbg
2021-07-28T13:34:10.0296382Z -- Building x64-linux-rel
2021-07-28T13:34:10.0297067Z -- Installing: /mnt/vcpkg-ci/packages/libzippp_x64-linux/share/libzippp/copyright
2021-07-28T13:34:10.0297719Z -- Performing post-build validation
2021-07-28T13:34:10.0298312Z -- Performing post-build validation done

So it looks like it fails because with the current changes, libzippp (which is my library, that I updated in #18553) do not compile. But with the log output, I'm unable to tell why (maybe related to the cmake configuration ?).

[JonLiu1993]

@ctabin ,Is this PR being worked on?

[JonLiu1993]

@dg0yt ,Do you have any advice?

[ctabin]

@JonLiu1993 Unfortunately not. As said, I'm unable to provide more help here because I'm unable to see/understand the error (and also I'm not the author of libzip).

[dg0yt]

It is too late to look at ignition-fuel-tools4 CI build logs, and too much to do locally now. But it is clear that it needs proper exported configuration from libzip. So I did a build of libzip now. Inspecting the pc file indicates an issue wit zstd:

Libs:  -L"${libdir}" -lzip  -lbz2 -lZstd::Zstd -lz

Now looking for zstd in the exported cmake config indicates a missing find_dependency:

% grep -i zstd packages/libzip_x64-osx/share/libzip/libzip-*
packages/libzip_x64-osx/share/libzip/libzip-targets.cmake:  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:BZip2::BZip2>;\$<LINK_ONLY:Zstd::Zstd>;\$<LINK_ONLY:ZLIB::ZLIB>"

This is just for a default build. Similar verification needs to be done for the optional features.

[JonLiu1993]

@dg0yt ,Thanks for your investigation and suggestions

[JonLiu1993]

@ctabin ，Have you verified according to @dg0yt's investigation and suggestions?

[JonLiu1993]

@ctabin ,Is there any progress on this pr?

[ctabin]

Hi @JonLiu1993, Unfortunately, no.
Since I'm not the author of libzip (only libzippp) and it seems the build has slightly changed, I'm unaware of the adaptations needed for vcpkg...
Maybe someone else should take over this PR to finish it properly.

[JonLiu1993]

Hi @JonLiu1993, Unfortunately, no. Since I'm not the author of libzip (only libzippp) and it seems the build has slightly changed, I'm unaware of the adaptations needed for vcpkg... Maybe someone else should take over this PR to finish it properly.

@ctabin ,Thanks for your contribution,I temporarily close your pr, I will resubmit pr to update libzip port

[ctabin]

@JonLiu1993 Thanks for your support.