Skip to content

[libe57] Add new port#18445

Merged
BillyONeal merged 11 commits intomicrosoft:masterfrom
maz-1:libe57
Jul 16, 2021
Merged

[libe57] Add new port#18445
BillyONeal merged 11 commits intomicrosoft:masterfrom
maz-1:libe57

Conversation

@maz-1
Copy link
Copy Markdown
Contributor

@maz-1 maz-1 commented Jun 14, 2021

Describe the pull request

  • What does your PR fix?

    Add support for libe57

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

    Every officially supported triplets builds without errors.
    No.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link
Copy Markdown

ghost commented Jun 14, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 15, 2021
Comment thread ports/libe57/portfile.cmake Outdated
Comment thread ports/libe57/vcpkg.json Outdated
Comment thread ports/libe57/portfile.cmake Outdated
@JonLiu1993
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JonLiu1993
Copy link
Copy Markdown
Contributor

@maz-1 ,Thanks for your pr.
If this pr has been modified, please click "ready for review" to let me know

@maz-1 maz-1 marked this pull request as ready for review June 27, 2021 02:32
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 6, 2021
@JonLiu1993 JonLiu1993 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 6, 2021
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Jul 6, 2021

@maz-1 ,There are too many modifications in those patches. Can you open an issue in upstream to let Upstream know?

Comment thread ports/libe57/portfile.cmake Outdated
Comment thread ports/libe57/portfile.cmake Outdated
Comment thread ports/libe57/portfile.cmake Outdated
Comment thread ports/libe57/portfile.cmake Outdated
Comment thread ports/libe57/portfile.cmake Outdated
@maz-1
Copy link
Copy Markdown
Contributor Author

maz-1 commented Jul 6, 2021

@maz-1 ,There are too many modifications in those patches. Can you open an issue in upstream to let Upstream know?

I opened a issue in their sourceforge bug reports, although it seems their bug reports are not actively maintained.

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jul 7, 2021
@JonLiu1993
Copy link
Copy Markdown
Contributor

@maz-1 ,Thanks for your new port!

@BillyONeal BillyONeal merged commit 04658e4 into microsoft:master Jul 16, 2021
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants