Skip to content

[libxml2] android and ios#18435

Closed
m-kuhn wants to merge 2 commits intomicrosoft:masterfrom
opengisch:libxml2
Closed

[libxml2] android and ios#18435
m-kuhn wants to merge 2 commits intomicrosoft:masterfrom
opengisch:libxml2

Conversation

@m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Jun 14, 2021

Add android and ios support to libxml2

@@ -0,0 +1,288 @@
/* config.h. Generated from config.h.in by configure. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to remove all the chaff from this file (comments, newlines) since it's being checked in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a generated file, I think there is value in leaving this (e.g. to compare it with files generated in other environments). But if it's desired I can remove it.

@Neumann-A
Copy link
Contributor

@ras0219 don't forget #17945 which removes the custom CMakeLists.txt

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Jun 14, 2021

@ras0219 don't forget #17945 which removes the custom CMakeLists.txt

Feel free to close this one in favor of #17945 anytime

@PhoebeHui PhoebeHui self-assigned this Jun 15, 2021
@PhoebeHui PhoebeHui added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jun 15, 2021
@PhoebeHui
Copy link
Contributor

Closing in favor of #17945

@PhoebeHui PhoebeHui closed this Jun 15, 2021
@m-kuhn m-kuhn deleted the libxml2 branch June 15, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants