[c4core, ryml] Add windows arm/arm64 support by ysc3839 · Pull Request #18316 · microsoft/vcpkg

ysc3839 · 2021-06-07T18:20:21Z

Describe the pull request

What does your PR fix?

Add arm/arm64 support for c4core and rapidyaml.
Which triplets are supported/not supported? Have you updated the CI baseline?

windows x86, x64, arm, arm64. Yes
Does your PR follow the maintainer guide?

I think yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

NancyLi1013 · 2021-06-08T02:58:56Z

Hi @ysc3839
Thanks for your PR.
This PR also includes the version update. Related PR #18230. I have a question why do you not use the latest commit?

ysc3839 · 2021-06-08T12:24:02Z

@NancyLi1013 Sorry, I didn't noticed PR #18230. I use this commit because latest rapidyaml references this commit as submodule. https://github.com/biojppm/rapidyaml/tree/master/ext

NancyLi1013 · 2021-06-09T02:10:59Z

Thanks for your clarification. @ysc3839

The failures on CI pipeline are like this, can you look into this?

D:\buildtrees\ryml\src\7de9381706-233508cf9e.clean\src\c4/yml/tree.hpp(675): error C2039: 'contains': is not a member of 'c4::basic_substring<char>'
D:\installed\x86-windows\include\c4/substr_fwd.hpp(11): note: see declaration of 'c4::basic_substring<char>'
D:\buildtrees\ryml\src\7de9381706-233508cf9e.clean\src\c4/yml/tree.hpp(777): error C2039: 'contains': is not a member of 'c4::basic_substring<char>'
D:\installed\x86-windows\include\c4/substr_fwd.hpp(11): note: see declaration of 'c4::basic_substring<char>'
D:\buildtrees\ryml\src\7de9381706-233508cf9e.clean\src\c4/yml/tree.hpp(778): error C2039: 'contains': is not a member of 'c4::basic_substring<char>'
D:\installed\x86-windows\include\c4/substr_fwd.hpp(11): note: see declaration of 'c4::basic_substring<char>'
D:\buildtrees\ryml\src\7de9381706-233508cf9e.clean\src\c4/yml/tree.hpp(782): error C2039: 'contains': is not a member of 'c4::basic_substring<char>'

ysc3839 · 2021-06-09T03:49:20Z

@NancyLi1013 rapidyaml needs update to latest version. I created another PR #18317.

NancyLi1013 · 2021-06-09T06:50:29Z

@NancyLi1013 rapidyaml needs update to latest version. I created another PR #18317.

I noticed that you commented #18317 also requires this PR here #18317 (comment).

In this case, I suggest to update these two ports in one PR. Otherwise, CI test will not pass.

ysc3839 · 2021-06-10T19:55:49Z

@NancyLi1013 I just merge changes for rapidyaml into this branch. Please review.

ysc3839 · 2021-06-11T04:42:27Z

@NancyLi1013 Fixed, please review.

NancyLi1013 · 2021-06-11T05:38:43Z

Please run ./vcpkg x-add-version --overwrite-version c4core ryml to update versions.

ysc3839 · 2021-06-11T17:10:51Z

@NancyLi1013 Fixed, please review.

NancyLi1013 · 2021-06-15T08:41:15Z

/azp run

azure-pipelines · 2021-06-15T08:41:23Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-06-16T06:08:11Z

Could you please merge master to resolve the conflicts? @ysc3839

ysc3839 · 2021-06-17T03:45:20Z

@NancyLi1013 Updated, please review.

ysc3839 · 2021-06-22T07:15:03Z

Fixed version error.

NancyLi1013 · 2021-06-23T10:06:04Z

Missing versions/baselin.json file. You can runvpkg x-add-version --overwrite-version --allto update.

ysc3839 · 2021-06-23T10:29:44Z

@NancyLi1013 After running vcpkg x-add-version --overwrite-version --all, the versions/baseline.json keep unchanged.

NancyLi1013 · 2021-06-24T01:56:40Z

@NancyLi1013 After running vcpkg x-add-version --overwrite-version --all, the versions/baseline.json keep unchanged.

Since you didn't update the version in CONTROL files. I have submitted the review suggestions, please update version first, then run the command. Sorry, I ignored this point before.

ysc3839 · 2021-06-24T02:17:50Z

@NancyLi1013 Fixed.

NancyLi1013 · 2021-06-25T03:11:53Z

LGTM now, thanks for your PR @ysc3839.

ysc3839 · 2021-06-25T04:01:25Z

@NancyLi1013 rapidyaml has merged my PR for ARM build issue. I will update this PR to remove the patches.

NancyLi1013 · 2021-06-25T05:37:40Z

@NancyLi1013 rapidyaml has merged my PR for ARM build issue. I will update this PR to remove the patches.

Thanks for your information. That's great.

ysc3839 · 2021-06-29T10:00:51Z

@NancyLi1013 Updated and rebased, please review.

NancyLi1013 · 2021-06-30T02:14:47Z

LGTM, thanks again for your work. @ysc3839

ysc3839 · 2021-07-14T04:13:58Z

@NancyLi1013 Is there any updates of this PR?

NancyLi1013 · 2021-07-14T05:57:07Z

@ras0219-msft , @vicroms Could you please help merge this PR?

Thanks.

BillyONeal · 2021-07-16T07:50:18Z

Sorry for the delay, thanks for the help!

ysc3839 mentioned this pull request Jun 7, 2021

[ryml] Add windows arm/arm64 support #18317

Closed

JonLiu1993 assigned NancyLi1013 Jun 8, 2021

NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 8, 2021

NancyLi1013 suggested changes Jun 8, 2021

View reviewed changes

Comment thread ports/c4core/CONTROL Outdated

Comment thread ports/c4core/portfile.cmake Outdated

Comment thread scripts/ci.baseline.txt Outdated

NancyLi1013 added the requires:author-response label Jun 8, 2021

ysc3839 force-pushed the c4core branch from 34dc36d to 4b210fa Compare June 8, 2021 19:03

MichaelGoulding reviewed Jun 10, 2021

View reviewed changes

Comment thread ports/c4core/fix-arm-build-error.patch Outdated

ysc3839 force-pushed the c4core branch from 4b210fa to f5322f2 Compare June 10, 2021 19:54

ysc3839 changed the title ~~[c4core] Add windows arm/arm64 support~~ [c4core, ryml] Add windows arm/arm64 support Jun 10, 2021

NancyLi1013 suggested changes Jun 11, 2021

View reviewed changes

Comment thread ports/ryml/CONTROL Outdated

Comment thread ports/ryml/portfile.cmake Outdated

ysc3839 force-pushed the c4core branch from f5322f2 to fb388c9 Compare June 11, 2021 04:42

ysc3839 force-pushed the c4core branch from fb388c9 to 60b6507 Compare June 11, 2021 17:10

NancyLi1013 approved these changes Jun 15, 2021

View reviewed changes

NancyLi1013 removed the requires:author-response label Jun 15, 2021

NancyLi1013 added the requires:author-response label Jun 16, 2021

ysc3839 force-pushed the c4core branch from 60b6507 to 24e14e4 Compare June 17, 2021 03:45

MichaelGoulding reviewed Jun 17, 2021

View reviewed changes

Comment thread ports/c4core/fix-fastfloat-arm-build-error.patch Outdated

ysc3839 force-pushed the c4core branch from 95f4892 to f18dcb3 Compare June 22, 2021 07:14

NancyLi1013 suggested changes Jun 24, 2021

View reviewed changes

Comment thread ports/c4core/vcpkg.json Outdated

Comment thread ports/ryml/vcpkg.json Outdated

ysc3839 force-pushed the c4core branch from f18dcb3 to 1817769 Compare June 24, 2021 02:17

NancyLi1013 approved these changes Jun 24, 2021

View reviewed changes

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jun 24, 2021

NancyLi1013 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 25, 2021

biojppm mentioned this pull request Jun 26, 2021

Issue pull request for vcpkg installer to update its version of rapidyaml. biojppm/rapidyaml#116

Closed

[c4core, ryml] Add windows arm/arm64 support

60f2f66

ysc3839 force-pushed the c4core branch from 1817769 to 60f2f66 Compare June 29, 2021 10:00

NancyLi1013 approved these changes Jun 30, 2021

View reviewed changes

NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 30, 2021

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 30, 2021

Merge remote-tracking branch 'origin/master' into HEAD

94a8d57

BillyONeal merged commit d90f71a into microsoft:master Jul 16, 2021

ysc3839 deleted the c4core branch July 16, 2021 08:05

Conversation

ysc3839 commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Jun 8, 2021

Uh oh!

ysc3839 commented Jun 8, 2021

Uh oh!

NancyLi1013 commented Jun 9, 2021

Uh oh!

ysc3839 commented Jun 9, 2021

Uh oh!

NancyLi1013 commented Jun 9, 2021

Uh oh!

Uh oh!

ysc3839 commented Jun 10, 2021

Uh oh!

Uh oh!

Uh oh!

ysc3839 commented Jun 11, 2021

Uh oh!

NancyLi1013 commented Jun 11, 2021

Uh oh!

ysc3839 commented Jun 11, 2021

Uh oh!

NancyLi1013 commented Jun 15, 2021

Uh oh!

azure-pipelines Bot commented Jun 15, 2021

Uh oh!

NancyLi1013 commented Jun 16, 2021

Uh oh!

ysc3839 commented Jun 17, 2021

Uh oh!

Uh oh!

ysc3839 commented Jun 22, 2021

Uh oh!

NancyLi1013 commented Jun 23, 2021

Uh oh!

ysc3839 commented Jun 23, 2021

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Jun 24, 2021

Uh oh!

ysc3839 commented Jun 24, 2021

Uh oh!

NancyLi1013 commented Jun 25, 2021

Uh oh!

ysc3839 commented Jun 25, 2021

Uh oh!

NancyLi1013 commented Jun 25, 2021

Uh oh!

ysc3839 commented Jun 29, 2021

Uh oh!

NancyLi1013 commented Jun 30, 2021

Uh oh!

ysc3839 commented Jul 14, 2021

Uh oh!

NancyLi1013 commented Jul 14, 2021

Uh oh!

BillyONeal commented Jul 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ysc3839 commented Jun 7, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?