[openblas] Add feature simplethread and thread#18265
Merged
strega-nil-ms merged 6 commits intomicrosoft:masterfrom Jun 10, 2021
Merged
[openblas] Add feature simplethread and thread#18265strega-nil-ms merged 6 commits intomicrosoft:masterfrom
strega-nil-ms merged 6 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-feature
Contributor
Author
|
@TonyXiang8787 Can you please test this PR? |
|
Tested! root@19bb598141b2:~/vcpkg# ./vcpkg install openblas --dry-run
Computing installation plan...
The following packages will be built and installed:
openblas[core,thread]:x64-linux -> 0.3.10#1
root@19bb598141b2:~/vcpkg# ./vcpkg install openblas[core] --dry-run
Computing installation plan...
The following packages will be built and installed:
openblas[core]:x64-linux -> 0.3.10#1
root@19bb598141b2:~/vcpkg# ./vcpkg install openblas[thread] --dry-run
Computing installation plan...
The following packages will be built and installed:
openblas[core,thread]:x64-linux -> 0.3.10#1
root@19bb598141b2:~/vcpkg# ./vcpkg install openblas[simplethread] --dry-run
Computing installation plan...
The following packages will be built and installed:
openblas[core,simplethread,thread]:x64-linux -> 0.3.10#1 |
Contributor
Author
|
@TonyXiang8787 Please note only openblas built with core uses single thread. |
|
@JackBoosY I understand. The default behavior is kept the same (multi-threading) as current version. |
JackBoosY
requested review from
NancyLi1013 and
PhoebeHui
and removed request for
NancyLi1013
JackBoosY
commented
Jun 7, 2021
JackBoosY
commented
Jun 7, 2021
PhoebeHui
approved these changes
Jun 7, 2021
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
|
Cool, thanks Jack! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feature
threadsandsimplethreadthat user can enable or disable them when building openblas.Fixes #15698.
Already tested all features successfully on
x86-windowsandx64-windows-static.