[d3d12-memory-allocator] new port#18212
Merged
BillyONeal merged 15 commits intomicrosoft:masterfrom Jul 16, 2021
Merged
Conversation
NancyLi1013
added
the
category:new-port
NancyLi1013
suggested changes
Jun 1, 2021
NancyLi1013
reviewed
Jun 1, 2021
NancyLi1013
suggested changes
Jun 1, 2021
Contributor
|
Have you tested the usage for this port? @crud89 |
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Contributor
Author
Yes. First, I have tried to install the port locally, which works when using my fork. Also I have integrated the fork into my project and referenced the port from there and wrote a small sample application that calls into the library. The sample builds and runs successfully. |
NancyLi1013
approved these changes
Jun 2, 2021
NancyLi1013
added
info:needs-maintainer-attention
Contributor
|
LGTM now, thanks for adding this port @crud89. |
strega-nil-ms
suggested changes
Jun 10, 2021
NancyLi1013
added
the
requires:vcpkg-team-review
ras0219-msft
suggested changes
Jun 24, 2021
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for the PR! This LGTM once my suggestion is applied.
ras0219-msft
removed
the
requires:vcpkg-team-review
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a port for the D3D12 Memory Allocator, a DirectX 12 counterpart for the already existing Vulkan Memory Allocator. The port creates an interface library target from the D3D12MemAlloc header and source files. The port was also requested in issue #17157. Due to the nature of DirectX, only Windows is supported.