Conversation
|
I'm working on fixing this, in multiple steps:
|
|
I do need help for one thing. It seems only Much appreciated! |
NancyLi1013
left a comment
There was a problem hiding this comment.
If we use new functions, vcpkg-cmake and vcpkg-cmake-config should be added to the dependencies.
"dependencies": [
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
|
Hi @WeiDaiWD Thanks. |
|
I've created a separate PR #18101 to fix port |
2b42eae to
950b29e
Compare
|
|
|
Will do. I've also just noticed that I have to make more changes to the patch, since hexl updated the commit hash for tag 1.1.0. |
|
LGTM now, thanks for adding this new port. @WeiDaiWD |
|
LGTM, thanks @WeiDaiWD :) |
Describe the pull request
What does your PR fix?
Added a new port "hexl".
Which triplets are supported/not supported? Have you updated the CI baseline?
x64 & (windows | linux | osx) & static
No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?I ran
./vcpkg x-add-version hexlfor this new port only.