vcpkg_configure_make: Fixes for mingw#18028
Closed
past-due wants to merge 3 commits intomicrosoft:masterfrom
Closed
vcpkg_configure_make: Fixes for mingw#18028past-due wants to merge 3 commits intomicrosoft:masterfrom
past-due wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Contributor
|
This is mostly duplicating work which already has pending PR. |
Contributor
|
PS: I would have more changes to vcpkg_configure_make, but there is no point in stacking more PRs. CI runs take long for changes to this script, and quite often they run into unrelated problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: Waiting on merge of #17137 and #17215 to rebase.
Describe the pull request
Various fixes / tweaks for
vcpkg_configure_makeand mingw.mingw: Do not use
compile/windres-rcwrappers.clang64environment) fail to build ports because LLVM's windres does not support the (Windows)-fooption.mingw: Use the vcpkg-acquired msys binaries for
objdump/nmclang64environment) cannot build ports as theirobjdumpis preferred and its output differs enough that it isn't properly parsed bylibtool.mingw: Remove
-luuidfrom default libs to avoidlibtoolerrors that break builds.uuidto prevent adding-luuidto the libs.Which triplets are supported/not supported? Have you updated the CI baseline?
mingw community triplets